black config - 120 chars?

[albertz]

I would propose the following pyproject.toml config:

[tool.black]
line-length = 120
target-version = ["py37"]

Currently black uses the default 88 chars. So this would change it to 120 chars. I personally would prefer that. Any objections?
I'm not so sure about the Python target-version but I guess Python >=3.7 is ok?

[JackTemaki]

I also prefer 120. Target version is ok.

[albertz]

Corresponding issue in i6_core: rwth-i6/i6_core#362

[albertz]

So, it is decided then? Or what exactly do we wait for now?

[JackTemaki]

we wait for any response in rwth-i6/i6_core#362

[albertz]

Why? Because you want it consistent to that? We can also decide independently here, or not?

[christophmluscher]

I would keep the decision consistent but the timing independent between core and experiments.

Since I have a number of PR on common/rasr, if possible, I would like to to the black with 120 on those files.

[albertz]

I mean, we can also argue that it should be consistent to RETURNN-common, or RETURNN.

But it anyway seems like most people vote for 120.

[christophmluscher]

IMHO core and experiments are both Sisyphus recipes. Returnn and returnn common are not.
I'd rather argue Sisyphus should have the same black rules than returnn

[albertz]

Ok, @curufinwe agreed to 120 chars in i6_core (rwth-i6/i6_core#362). I guess it is decided then that we use 120 chars both here in i6_exp and in i6_core.

I will just apply it directly here in i6_exp. Someone else can do it for i6_core.