Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change indentation to 4 spaces? #1156

Closed
albertz opened this issue Oct 19, 2022 · 6 comments · Fixed by #1255
Closed

Change indentation to 4 spaces? #1156

albertz opened this issue Oct 19, 2022 · 6 comments · Fixed by #1255

Comments

@albertz
Copy link
Member

albertz commented Oct 19, 2022

This was basically decided now for returnn-common: rwth-i6/returnn_common#208

It probably also makes sense here.

Or are there any good arguments not to do this?

@albertz
Copy link
Member Author

albertz commented Oct 19, 2022

@JackTemaki
Copy link
Collaborator

Sounds good! Would be more standard, and then one less RETURNN specific setting in PyCharm compared to other projects.

@mmz33
Copy link
Member

mmz33 commented Oct 19, 2022

I would also vote for 4 spaces indent.

@michelwi
Copy link
Collaborator

I don't have a strong opinion, but would vote for consistency to other projects. -> 4 spaces.

@albertz albertz mentioned this issue Oct 19, 2022
@christophmluscher
Copy link
Collaborator

I also support 4 spaces

@braddockcg
Copy link

4 spaces, definitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants