Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply black, indent by 4 spaces #1255

Merged
merged 17 commits into from
Feb 3, 2023
Merged

Apply black, indent by 4 spaces #1255

merged 17 commits into from
Feb 3, 2023

Conversation

albertz
Copy link
Member

@albertz albertz commented Feb 3, 2023

Fix #1158. Fix #1156.

Partly overtaken from rwth-i6/returnn_common#251.

Also, this breaks Python 2 now, because Black does not support it anymore, and reformats some files in a way that are incompatible to Python 2. So it also fixes #487.

After this, you should update your PyCharm settings. See the updated wiki page: https://github.com/rwth-i6/returnn/wiki/PyCharm-Configuration

@albertz albertz marked this pull request as ready for review February 3, 2023 16:13
@albertz albertz requested review from patrick-wilken, JackTemaki and a team as code owners February 3, 2023 16:13
@albertz albertz merged commit fc861be into master Feb 3, 2023
@albertz albertz deleted the albert-black-indent4sp-1158 branch February 3, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply black? Change indentation to 4 spaces? Drop older Python support, require Python >=3.7
1 participant