Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new github workflow to build release binaries #696

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

adoy
Copy link
Contributor

@adoy adoy commented Sep 11, 2023

This is the first step to release monstache for multiple architectures.
Goreleaser is used to automatically create and upload all the binaries.

Fixes #528 and also fixes #655

Also in the build I'm using CGO_ENABLED=0 to remove the dependency to musl/libc. I don't think you're using Cgo anywhere but feel free to double check and correct me if i'm wrong.

You can find an exemple here : https://github.com/adoy/monstache/releases/tag/1.0.2

Next step will be to automatically build docker images for multiple platforms (as there is only the amd64 one currently).

@adoy adoy mentioned this pull request Sep 11, 2023
@adoy
Copy link
Contributor Author

adoy commented Sep 11, 2023

Also, I've just seen that you've created a new version. You should be able to run the workflow manually for this version to create all the binaries.

Use goreleaser to automatically build binaries for various platforms and
upload the binaries to the release.
Copy link
Owner

@rwynn rwynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adoy thanks for bearing with me on this. The work looks great. Just had 1 more request and a couple of questions. I did check out the release output on your fork and it looks good to me.

.github/workflows/release-binaries.yaml Outdated Show resolved Hide resolved
.github/workflows/release-binaries.yaml Show resolved Hide resolved
.goreleaser.yaml Show resolved Hide resolved
@rwynn rwynn merged commit 5b04fb5 into rwynn:rel6 Sep 15, 2023
@adoy adoy deleted the feature/release-workflow branch September 15, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arm64 ARM64 support
2 participants