Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically build and push multiarch docker images on Release #697

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

adoy
Copy link
Contributor

@adoy adoy commented Sep 11, 2023

This new workflow is the second and last step (after #696) to release monstache for multiple architectures.

It will automatically generate docker images for latest, rel6 and also push images with semantic versionning. For example release v6.7.12 would push

monstache:latest
monstache:rel6
monstache:6
monstache:6.7
monstache:6.7.12

I did not use the base version of the image as you did previously, but based it directly on alpine. I think it make things more complicated, and since all the build is now done automatically the extra seconds are not a problem anymore.

You can find an exemple of the output here : https://hub.docker.com/r/adoy/monstache/tags (I will delete this repo once merged).

@adoy
Copy link
Contributor Author

adoy commented Sep 11, 2023

PS: The same workflow can be applied after that to handle rel5 and not to push lastest in this case, but I will submit a new PR for the rel5 branch once this one is approved.

@adoy adoy mentioned this pull request Sep 11, 2023
.github/workflows/release-docker-images.yml Outdated Show resolved Hide resolved
.github/workflows/release-docker-images.yml Outdated Show resolved Hide resolved
- name: Login to Docker Hub
uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
Copy link
Contributor Author

@adoy adoy Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwynn Remember to add those 2 variables (DOCKERHUB_USERNAME, DOCKERHUB_TOKEN) before triggering the build :)

@rwynn rwynn merged commit e899d54 into rwynn:rel6 Sep 20, 2023
@adoy adoy deleted the feature/release-docker-workflow branch September 20, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants