Switch to css imports rather than css_files hackery.

[ryan-roemer]

The theme uses css_files hackery, but that is deprecated in modern Sphinx and error prone because there are real object instances and not strings that now comprise css_files. See, e.g. #158

This PR switches all of the conditionally-included CSS files into css @import url("NAME.css"); statements and just now has one root style sheet included the old fashioned way. Hopefully this is both backwards compatible with any previous Sphinx versions and works better as css_files goes off into deprecation sunset.

Would appreciate folks pulling this down and kicking the tires!

/cc @alexhagen @has2k1 @pcav

[alexhagen]

Works with no warnings for my purposes with sphinx 1.6.2 and sphinx 1.6.1 with a default bootswatch Journal stylesheet.

However, the css override done in _templates/layout.html

{% set bootswatch_css_custom = ['_static/bootstrap.css'] %}

no longer overrides the stylesheet. Is there a new/different api for custom css overrides?

[has2k1]

I have the same issue as @alexhagen

In _templates/layout.html this

{# Import the theme's layout. #}
{% extends "!layout.html" %}

{# Custom CSS overrides #}
{% set bootswatch_css_custom = ['_static/custom.css'] %}

does not include the custom css file.

[ryan-roemer]

It should actually be:

{% set bootswatch_css_custom = ['custom.css'] %}

Without the _static because it's relative, but it's still not working in my demo because I think the CSS template processing happens before layout.html, so I'll need to come up with another approach.

This use case here is really "add CSS stylesheets at the end", so ideally I'll find something more idiomatic and sustainable than this...

[has2k1]

What about the other bootstrap css files that are not included. Is it the same issue

These ones

<link rel="stylesheet" href="_static/bootstrap-3.3.6/css/bootstrap.min.css" type="text/css" />
<link rel="stylesheet" href="_static/bootstrap-3.3.6/css/bootstrap-theme.min.css" type="text/css" />

Though, I do not see any effect on the styling due them being absent.

[ryan-roemer]

Those should correctly be imported using the CSS style import now. I forget how it shows up in the dev tools, but if you look at your Web servers access log all the correct CSS files should be accessed.

I'm still working on the customization problem

[ryan-roemer]

@alexhagen @has2k1 @pcav @jaraco -- OK, I've updated the documentation for doing custom CSS to make it (1) generic and (2) have documented strategies for Sphinx before and after 1.5 (since things are radically different).

See here: https://github.com/ryan-roemer/sphinx-bootstrap-theme/blob/0ecb1832f1ed53656392b702073e1d0513b8cbb6/README.rst#adding-custom-css

Let me know how everything looks for:

• Rendering stuff in Sphinx 1.5 and 1.6
• The same with custom CSS overrides via the newly documented solutions

Thanks!

[has2k1]

@ryan-roemer, it works well. Added advantage is that now you add extra css the same way you add extra javascript.

[alexhagen]

@ryan-roemer I agree with @has2k1 , I like the API. Thanks again!

[ryan-roemer]

Released in https://pypi.python.org/pypi/sphinx-bootstrap-theme/0.5.0