-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AnonymousPro: Still blurred fonts #1174
Comments
The patched Edit: Correct typo |
Maybe the font is too old. Multiple bugs tackling baseline-to-baseline spacing and also regarding hinting/antialiasing have been fixed for |
Is 'Original Anonymous Pro' our source or the real source? Because I just noticed we patch a patched version 🙄 |
Obviously the font we use as source is a Interestingly the Minus variant (without embedded bitmaps) is available as 1.003 while the ttf with bitmaps in only availabe as 1.002. I would update our source to the original source. The question remains if you used a self patched font (from the original source), or a pre-patched font? I see that a lot of settings are lost in our source (all the stuff that I guess I have a build-from-source |
Regarding 3... I just tried to exchange the Anonymous Pro to the real repo (https://www.marksimonson.com/fonts/view/anonymous-pro), but that font triggers a bug in fontforge :-( fontforge/fontforge#5230 So now I started to debug |
[why] We use a prepatched font not the original Anonymous Pro. The prepatched font contains no bitmaps and is thus like Anonymous Pro Minus. Also some font internals that fontforge does not copy out of the box are differing. And we miss the Bold and Italic variants. [how] Crossgrade to original Anonymous Pro as source and add the missing weight/style. Add Anonymous to SIL. Handle 'Pro' naming parts (do not detect 'r' as short for 'Regular'). [note] Maybe related: #1174 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
So the issue is in fonrforge which means you cant do anything about that? |
No, at least I do not believe that. When I use the original Anonymous Pro I'm not sure what that means. Anyhow, the bitmaps are only in sizes 10..13, and I guess you see the problem also with bigger sizes? Your screenshot looks like bigger size. I have very limited knowledge about bitmap fonts, while according to #329 you have :-) Before commit 946c1d0 I can prepare you a new As I showed, I can not see the effect right now. And/or it would be helpful to check if the effect is also there in other applications. Other terminals and also text processors like |
See ryanoasis#1174 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Please find the patched-with-bitmaps fonts here: https://github.com/Finii/nerd-fonts/tree/master/patched-fonts/AnonymousPro |
Already did the change to bitmap embedded Anonymous Pro with #1175. Please check after Closing for now. |
[why] We use a prepatched font not the original Anonymous Pro. The prepatched font contains no bitmaps and is thus like Anonymous Pro Minus. Also some font internals that fontforge does not copy out of the box are differing. And we miss the Bold and Italic variants. [how] Crossgrade to original Anonymous Pro as source and add the missing weight/style. Add Anonymous to SIL. Handle 'Pro' naming parts (do not detect 'r' as short for 'Regular'). [note] Maybe related: ryanoasis#1174 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
Back then I reported this issue. Today I tried new fonts (2 months old) and there is a certain advance but the result is not perfect. See:
Original Anonymous Pro
Patched version
Sizing and spacing seems good but the font is lil bit blurred out and faded.
Terminal: Alacritty 0.12
The text was updated successfully, but these errors were encountered: