-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patched Terminess fonts still blurry #1329
Comments
I'm mostly creating this issue because I can patch the fonts manually, but I can't seem to figure out how to fix the actual repo to get clean bitmap fonts. I think it might be the same issue as #1174 for AnonymousPro, but I'm not sure what the fix in #1175 actually does to resolve it. I wouldn't be surprised if a few other bitmap fonts are having the same issue. |
Thanks for reporting. Can you provide the output of the patcher with
How do you do that? The AnonymousPro issue was that we used a font without bitmaps as source, of course there are no bitmaps than in the patched version. Changing to a AnonymousPro-with-bitmaps resulted in a patched AnonymousPro with bitmaps 😬 The unpatched Terminus source we use seems to have bitmaps...: and so does the patched font...: |
@Finii - Sure, I can replicate this by using the [nix-shell:~]$ cp /nix/store/r3hizlibf6bv79ydaxyd9chfsp1783yl-terminus-font-4.49.1/share/fonts/terminus/ter-u12n.otb .
[nix-shell:~]$ chmod +w ter-u12n.otb
[nix-shell:~]$ nerd-font-patcher ter-u12n.otb
No configfile given, skipping configfile related actions
Nerd Fonts Patcher v2.2.2 (3.0.5) executing
Adding 59 Glyphs from Seti-UI + Custom Set
╢████████████████████████████████████████╟ 100%
Adding 198 Glyphs from Devicons Set
╢████████████████████████████████████████╟ 100%
Done with Patch Sets, generating font...
Changing lowestRecPPEM from 8 to 12
Generated: Terminess Regular Nerd Font in './Terminess Regular Nerd Font.otb' And the result is this: Note that I have tried playing with my system's fontconfig settings and toggling Maybe the difference is using the TerminessTTF as the base? I could try using that and see what happens. EDIT: Can't seem to run with that debug option: |
Your patcher is too old |
I guess (gut feeling) that |
Huh, the fonts themselves are v3.0.2 in NixOS, but not the patcher. That's odd. I'll take a look and try to get the patcher updated for this distro.
The screenshots are actually from |
I would use
|
Alright, so apparently we did have 3.0.2 in Nixpkgs, but I mistakenly used an out of date version. Here is the output of the current one: $ nerd-font-patcher --debug 2 ter-u12n.otb
Nerd Fonts Patcher v3.0.2 (4.4.0) (ff 20230101)
DEBUG: Naming mode 1
DEBUG: Monospace check: Panose says "monospaced"; glyph-width-mono True
DEBUG: Final font cell dimensions 512 w x 1024 h
DEBUG: 150/160 box drawing glyphs will be replaced
Adding 180 Glyphs from Seti-UI + Custom Set
╢████████████████████████████████████████╟ 100%
Adding 6 Glyphs from Heavy Angle Brackets Set
╢████████████████████████████████████████╟ 100%
Adding 160 Glyphs from Box Drawing Set
╢████████████████████████████████████████╟ 100%
Adding 198 Glyphs from Devicons Set
╢████████████████████████████████████████╟ 100%
Done with Patch Sets, generating font...
DEBUG: =====> Family (ID 1) ok (19 <=31): Terminess Nerd Font
DEBUG: =====> SubFamily (ID 2) ok ( 7 <=31): Regular
DEBUG: =====> Fullname (ID 4) ok (19 <=63): Terminess Nerd Font
DEBUG: =====> PSN (ID 6) ok (19 <=63): TerminessNF-Regular
DEBUG: Preserving bitmaps (12,)
Terminess Nerd Font
\===> 'TerminessNerdFont-Regular.otb' Oddly enough, now the output seems to be blurry: I do notice that the font sizes are not integer based. For some reason I can only select 8.2, 8.7, 9.2, 9.7, 10.2, etc. Perhaps related? (Note, I can "force" 10px, but doesn't make any difference, still has that slight blur) The fact that the output of v2.2.2 did not look blurry is also interesting, and perhaps provides a bit more info on what the issue might be? EDIT: I get the same blurry result when patching TerminusTTF. Here's the debug output: $ nerd-font-patcher --debug 2 TerminusTTF.ttf
Nerd Fonts Patcher v3.0.2 (4.4.0) (ff 20230101)
DEBUG: Naming mode 1
The glyph named Tcommaaccent is mapped to U+021A.
But its name indicates it should be mapped to U+0162.
The glyph named tcommaaccent is mapped to U+021B.
But its name indicates it should be mapped to U+0163.
The glyph named Delta is mapped to U+0394.
But its name indicates it should be mapped to U+2206.
The glyph named Omega is mapped to U+03A9.
But its name indicates it should be mapped to U+2126.
DEBUG: Monospace check: Panose says "monospaced"; glyph-width-mono True
INFO: Redistributing line gap of 90 (45 top and 45 bottom)
DEBUG: Extended glyphs wider bounding box than basic glyphs
DEBUG: Final font cell dimensions 500 w x 1090 h
DEBUG: 150/160 box drawing glyphs will be replaced
Adding 180 Glyphs from Seti-UI + Custom Set
╢████████████████████████████████████████╟ 100%
Adding 6 Glyphs from Heavy Angle Brackets Set
╢████████████████████████████████████████╟ 100%
Adding 160 Glyphs from Box Drawing Set
╢████████████████████████████████████████╟ 100%
Adding 198 Glyphs from Devicons Set
╢████████████████████████████████████████╟ 100%
Done with Patch Sets, generating font...
DEBUG: =====> Family (ID 1) ok (19 <=31): Terminess Nerd Font
DEBUG: =====> SubFamily (ID 2) ok ( 7 <=31): Regular
DEBUG: =====> Fullname (ID 4) ok (19 <=63): Terminess Nerd Font
DEBUG: =====> PSN (ID 6) ok (11 <=63): TerminessNF
DEBUG: Preserving bitmaps (12, 14, 16, 18, 20, 22, 24, 28, 32)
DEBUG: Tweaking 1/1
Terminess Nerd Font
\===> 'TerminessNerdFont-Regular.ttf' Let me know if you'd like any other information or anything I should try. |
Thanks for the investigation!
That is, in I must confess I personally never use bitmap fonts and my knowledge about bitmap fonts is centuries old (i.e. before ttf and / or when X was more or less bitmap fonts only). But I will try to find something out. In the light of the changed selectable sizes I fear it might be |
The Though I can confirm the same result in There's a difference in both the characters and the spacing from the looks of it. I'm not certain both EDIT: Also, just in case it might have been an issue with the |
Just to add another datapoint for a different font renderer, here is Firefox rendering the different versions of the font. Only the Nerd Fonts version has the blur: Not sure what other apps I can use to see if it's a rendering issue or not. Unfortunately my knowledge of how fonts, font rendering, and how the font patcher works is next to nothing. |
Found this issue while having the same exact problem as OP, managed to figure a workaround. I'll post it in case someone else stumbles here:
Had to change the
|
Thanks for the feedback @herself I will look into it before 3.2. |
@allcontributors please add @Slabity for bug |
I've put up a pull request to add @Slabity! 🎉 |
In fact I do not really know if that solves @Slabity blurryness problem. It can also be a hinting problem, if the embedded bitmaps are not used. If your problem persists I can try and throw |
Ah yes... Hmm, but ... of course the original also has no hints, so that should not be the problem. You use testingOn my machine even the unpatched font is unsharp in Interestingly tbc |
Alacritty seems to have 'a problem' when a font is not all-bitmaps it will switch to LCD subpixel rendering and there is no way to prevent that? See for example Maybe they fixed it in the meantime, but not having an option to influence antialiasing (subpixel rendering) is a strange choice. If this is the problem we can not do anything about it. You can patch your I guess bitmap fonts and patching just does not blend very well. |
[why] The outlines in Terminus 4.49.2 are rather weird. Autoconverted but not too nice. [how] Update to 4.49.3 as tis has much better outlines. Fixes: ryanoasis#1329 Suggested-by: Wiesław Herr @herself Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii - I don't think this is fixed. I'm seeing the same results on v3.2.1 |
@Finii I also think this isn't fixed in v3.2.1. Noticed it on alacritty, but I see the same in Gnome "console" in NixOS |
🗹 Requirements
(Note that there are some older issues reported for this, but are locked for being stale)
🎯 Subject of the issue
Experienced behavior:
Decided to try using the patched Terminess fonts again since #329 was patched, but the font still looks blurry.
Here's a screenshot of the current, patched font at 10px:
Expected behavior:
Here's a screenshot of the unpatched font, also at 10px:
(Note the size doesn't affect the blurriness, it's blurry at all sizes).
Also, it looks fine when I patch it manually myself (this one is 8px though):
Example symbols:
Pretty much all of them.
🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf
)?TerminessNerdFont-Regular.ttf
iterm2
,urxvt
,gnome
,konsole
)?alacritty
, but screenshots are from font-manager★ Screenshots (Optional)
Posted above in behavior sections
The text was updated successfully, but these errors were encountered: