nf-hack behaves differently than the original hack-font #1245
Comments
|
Sorry to see your problem. All pre-existing Powerline glyphs are (have to be) dropped when a font is Nerd Fonts patched. But I will check why there are differences. By displaced 1 px you mean sidewards (1 px to the right)? What you can try is to switch to monospaced antialiasing, that should remove the faint greenish line after "zeus". It is indeed possible to generate a font that does not show the faint lines (see #780), but that raises other problems in other terminals, so what we do not is a compromise. But I will check original Hack, how they solve it. But please do write if this is your problem or something else? |
|
@Finii I think you are right, but the faint line is there regardless if i use the monospaced font or not, just some symbols (like the arch logo) are smaller in the monospace variant, the faint aliased line persists, or better "is unchanged". But yes, this is my problem :) |
|
interesting note on top of that: if i increase the vertical spacing between the lines in konsole, the effects gets even more pronounced (but i guess this comes from how |
|
We have the least amount of overlap. Maybe we should revive that. Also our glyph has no "overlap patch" but is a simple triangle which becomes more and more problematic when overlap is increased. Maybe we want to have this in 3.1.0, I would not change behavior again already in a bugfix release. |
|
Somehow the cell height is higher than intended here:
Hmm, |
It is the default-terminal of KDE/plasma :) |
Well, I guess the open triangle thing (also in my image above, the right one) has NO problem.
|
|
Aaron really added that overlap surface to all relevant glyphs
That is far better than the overlap. I think we should mimic that for 3.1 |
lol, awesome finding :) |
|
But he did not even clean up the insane amount of points in waveform or flames, just copied them unchanged over from here (and adding the side surface) 😬 Note to self: Clean that stuff up, opening the glyphs flame and waveform takes ages. |
I think it's a good idea to do that because this problem also presents in SymbolsNerdFont-Regular.ttf. This means that any aliases in the 10-nerd-font-symbols.conf will be affected. for example with Cascadia Code default: Replace |
|
WTF, it has an outline?!!
Editing and simplifying. |
[why] The waveform glyphs E0C8 and E0CA have an incredable amount of points and rendering is rather expensive. It turned out that it has a hairline ourline, that will be invisible anyhow. [how] Remove the Hairline, reducing the number of points to 1/3. [note] See #1245 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] We still fight with the faint lines on the big side of the powerline glyphs. They come from the LCD antialiasing mode that has problems with the borders. Other fonts use far more overlap. We use only a modest amount of overlap (2% of the width). [how] As the other fonts do, increase the overlap (to 7% now). We could not do that before, because we had no full-hight 'landing platforms' on the outsides and so the triangle would look cut off at not 100% hight. Now with the landing platforms we can increase the overlap and still have nice looking triangles that visibly reach the top and bottom of the line. Implement this only for the filled triangles to see how it goes. Related: #1245 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
Okay, I just changed the full left and right triangles. Lets see if this is good; then we can expand to the other powerline glyphs. |
|
Awesome! Will test it right away, as soon the release is out! However, shouldn't this issue be kept open (because it affects most likely many symbols, that aren't patched yet?)? |
|
And we need to check that it works for the one icon at all ;-) |
[why] The waveform glyphs E0C8 and E0CA have an incredable amount of points and rendering is rather expensive. It turned out that it has a hairline ourline, that will be invisible anyhow. [how] Remove the Hairline, reducing the number of points to 1/3. [note] See ryanoasis#1245 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] We still fight with the faint lines on the big side of the powerline glyphs. They come from the LCD antialiasing mode that has problems with the borders. Other fonts use far more overlap. We use only a modest amount of overlap (2% of the width). [how] As the other fonts do, increase the overlap (to 7% now). We could not do that before, because we had no full-hight 'landing platforms' on the outsides and so the triangle would look cut off at not 100% hight. Now with the landing platforms we can increase the overlap and still have nice looking triangles that visibly reach the top and bottom of the line. Implement this only for the filled triangles to see how it goes. Related: ryanoasis#1245 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] We still fight with the faint lines on the big side of the powerline glyphs. They come from the LCD antialiasing mode that has problems with the borders. Other fonts use far more overlap. We use only a modest amount of overlap (1% of the width). [how] As the other fonts do, increase the overlap (to 6% now). Add full-hight 'landing platforms' on the outsides of the glyphs, which are 7% wide. Related: a8b9e1d Related: #1245 Fixes: #1547 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
Closing as release is near now, so that I can sort out what is still missing. |
[why] We still fight with the faint lines on the big side of the powerline glyphs. They come from the LCD antialiasing mode that has problems with the borders. Other fonts use far more overlap. We use only a modest amount of overlap (1% of the width). [how] As the other fonts do, increase the overlap (to 6% now). Add full-hight 'landing platforms' on the outsides of the glyphs, which are 7% wide. Related: a8b9e1d Related: ryanoasis#1245 Fixes: ryanoasis#1547 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
just to report back, because i didn*t yet explicitly: i recently updated my nerd-fonts via the oh-my-posh font-installer ( Thanks for your effort. |
|
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
🗹 Requirements
🎯 Subject of the issue
Experienced behavior:
On
Arch(x86_64, Kernel 6.3.2) withBashonKonsole(23.04.1) andoh-my-poshthe hack-font provided by the arch-repos (extra/ttf-hack 3.003-3) behaves differently on rendering e.g. powerline-symbols. The original hack-font already contains some powerline-symbols (which do render correctly inkonsole), but the nf-hack font slightly squishes the symbols together (depending on font-size. however, the usable range is broken anyways, i usually use fonsize 10.0). On the example of theright|left-hard-devidericons, it looks like, as if the triangle is misplaced by 1px or so, see screenshots for details. While it doesn't look super-annoying, the original hack-font renders differently. So far i tested some more fonts (but without direct comparison to their original counterpart), namely dejavu-sans, 3270, anonymice-pro, meslo and sourcecode pro, but all of them seem to render slightly off, so i thought this was a konsole-issue, however, og-hack renders fine... (tested basically all other konsole-options which might have an influence but with no result)Expected behavior:
Both fonts should behave identical
Example symbols:
🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf)?HackNerdFont-Regular.ttf(but applies to mono-variants as well as other nf-fonts as well)oh-my-posh)iterm2,urxvt,gnome,konsole)?★ Screenshots (Optional)
fonsize=10:
original hack-font:
nf-hack:
another example with more colors:
The text was updated successfully, but these errors were encountered: