Increase Powerline glyph overlap #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The waveform glyphs E0C8 and E0CA have an incredable amount of points and rendering is rather expensive. It turned out that it has a hairline ourline, that will be invisible anyhow. [how] Remove the Hairline, reducing the number of points to 1/3. [note] See #1245 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] We still fight with the faint lines on the big side of the powerline glyphs. They come from the LCD antialiasing mode that has problems with the borders. Other fonts use far more overlap. We use only a modest amount of overlap (2% of the width). [how] As the other fonts do, increase the overlap (to 7% now). We could not do that before, because we had no full-hight 'landing platforms' on the outsides and so the triangle would look cut off at not 100% hight. Now with the landing platforms we can increase the overlap and still have nice looking triangles that visibly reach the top and bottom of the line. Implement this only for the filled triangles to see how it goes. Related: #1245 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
I wrote 7% in the commit message and in the comment above, but in reality it's only 6% 😬 |
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
…ph-overlap Increase Powerline glyph overlap
2 tasks
This was referenced Mar 20, 2024
Finii
added a commit
that referenced
this pull request
Oct 28, 2024
[why] There are still the annoying vertical colored lines sometimes that turn up due to subpixel rendering. [how] Add "landing platforms" to the big triangular glyphs (E0B8, E0BA, E0BC, E0BE) and flames (E0C0, E0C2). The landing platform is approx 7% wide based on one-cell width, assuming the glyphs are all rendered 2 cells wide. Increase the overlap width for patching to 5%. See also: Merge request #1551 Merge request #1419 Commit 5e28586 Commit a8b9e1d Fixes: #1629 (well, not the top problem which is unfixable) Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
4 tasks
Finii
added a commit
that referenced
this pull request
Oct 28, 2024
[why] There are still the annoying vertical colored lines sometimes that turn up due to subpixel rendering. [how] Add "landing platforms" to the big triangular glyphs (E0B8, E0BA, E0BC, E0BE) and flames (E0C0, E0C2). The landing platform is approx 7% wide (based on one-cell width, assuming the glyphs are all rendered 2 cells wide for the "xy2" ones). Increase the overlap width for patching to 5%. See also: Merge request #1551 Merge request #1419 Commit 5e28586 Commit a8b9e1d Fixes: #1629 (well, not the top problem which is unfixable) Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[why]
We still fight with the faint lines on the big side of the powerline
glyphs. They come from the LCD antialiasing mode that has problems with
the borders.
Other fonts use far more overlap. We use only a modest amount of overlap
(2% of the width).
[how]
As the other fonts do, increase the overlap (to 7% now). We could not do
that before, because we had no full-height 'landing platforms' on the
outsides and so the triangle would look cut off at not 100% height.
Now with the landing platforms we can increase the overlap and still
have nice looking triangles that visibly reach the top and bottom of the
line.
Implement this only for the filled triangles to see how it goes.
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Fixes #1245 (maybe, at least partially)
Screenshots (if appropriate or helpful)
left: before, right: after