Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Powerline overlap (big triangles and more) #1724

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Oct 28, 2024

[why]
There are still the annoying vertical colored lines sometimes that turn up due to subpixel rendering.

[how]
Add "landing platforms" to the big triangular glyphs (E0B8, E0BA, E0BC, E0BE) and flames (E0C0, E0C2).
The landing platform is approx 7% wide based on one-cell width, assuming the glyphs are all rendered 2 cells wide.

Increase the overlap width for patching to 5%.

See also:
Merge request #1551
Merge request #1419
Commit 5e28586
Commit a8b9e1d

Fixes: #1629 (well, not the top problem which is unfixable)

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
    Issue number where discussion took place: #xxx
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: xxx

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@Finii Finii added this to the v3.3.0 milestone Oct 28, 2024
[why]
There are still the annoying vertical colored lines sometimes that turn
up due to subpixel rendering.

[how]
Add "landing platforms" to the big triangular glyphs (E0B8, E0BA, E0BC,
E0BE) and flames (E0C0, E0C2).
The landing platform is approx 7% wide (based on one-cell width, assuming
the glyphs are all rendered 2 cells wide for the "xy2" ones).

Increase the overlap width for patching to 5%.

See also:
Merge request #1551
Merge request #1419
Commit 5e28586
Commit a8b9e1d

Fixes: #1629 (well, not the top problem which is unfixable)

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii force-pushed the feature/more-landing-platforms branch from 7a2e683 to 525b634 Compare October 28, 2024 22:13
@Finii Finii marked this pull request as ready for review October 28, 2024 22:15
@Finii Finii merged commit 02cd12e into master Oct 28, 2024
4 checks passed
@Finii Finii deleted the feature/more-landing-platforms branch October 28, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing 1px line at the top of upper-left and upper-right triangles
1 participant