-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
font validation failed, installing Meslo font #413
Comments
@zno5 Thanks for the report, low priority issue but issue non-the-less. Is it the same warning with regular Meslo font (non Nerd Font patched) ? |
I have the same problem with Meslo LG M Bold Nerd Font Complete Mono.ttf |
@ryanoasis Fwiw I had the same issue when patching SF Mono recently (which felt like a regression because I didn't use to have that issue). What "fixed" it for me was to add this little stinker before the
Whereas the To summarise: Results in bad name table:
Results in good name table:
EDIT: On top of that I found that to fix the "full name" (as presented by macOS' font book) requires to work around a quirk - macOS generates this name from the Windows font properties, which are not always overwritten by fontforge. To fix this one has to first set the |
The |
When pulling the subfamily out of the sfnt_names SubFamily property, we will get a subfamily with possible spaces, e.g. 'Bold Italic'. When constructing the final unique font name (PostScript name), we need to remove those spaces, to make the font name valid, otherwise the font will fail validation with a warning when installing. Fixes ryanoasis#413
Fixed in #820. Only the font name (PS name) needs sanitation. |
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
When pulling the subfamily out of the sfnt_names SubFamily property, we will get a subfamily with possible spaces, e.g. 'Bold Italic'. When constructing the final unique font name (PostScript name), we need to remove those spaces, to make the font name valid, otherwise the font will fail validation with a warning when installing. Fixes ryanoasis#413
🎯 font validation failed
Font validation has failed when I install Meslo bold italic font.
Other fonts(bold, italic, regular) are fine.
The problem is name table usability has caution.
🔧 Your Setup
★ Optional
The text was updated successfully, but these errors were encountered: