font-patcher: Ensure PostScript font name does not contain spaces #820
Conversation
When pulling the subfamily out of the sfnt_names SubFamily property, we will get a subfamily with possible spaces, e.g. 'Bold Italic'. When constructing the final unique font name (PostScript name), we need to remove those spaces, to make the font name valid, otherwise the font will fail validation with a warning when installing. Fixes ryanoasis#413
|
We had trouble processing your request. Please try again later. |
|
The SubFamily Naming in broken in multiple ways anyhow, I do not know if fixing individual aspects is useful anymore. On the other hand this change is small ;-) |
|
I'm not against merging THIS, as I fear it will still be a long time until 717's Just noticed And then, is the option name a good name? |
|
It's not documented at all, just mentioned in the commit 251de5a :-( |
|
Okey, reopening in case we want to merge it |
|
Merged directly, because I wanted a FF merge and could not push to your repo. Commit 6acec45
|
When pulling the subfamily out of the sfnt_names SubFamily property,
we will get a subfamily with possible spaces, e.g. 'Bold Italic'.
When constructing the final unique font name (PostScript name), we
need to remove those spaces, to make the font name valid, otherwise
the font will fail validation with a warning when installing.
Fixes #413