Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Traefik ingress is misconfigured, Access-Control-Expose-Headers must be set to '*' #89

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

votdev
Copy link
Contributor

@votdev votdev commented Mar 24, 2023

Fixes: https://github.com/aquarist-labs/s3gw/issues/410

The accessControlExposeHeaders property is set to * now to expose all headers by default. To fix the mentioned issue adding the X-Amz-Object-Lock-Mode and X-Amz-Object-Lock-Retain-Until-Date would be sufficient, but the problem might appear again in the future, but with a different header that is processed by the AWS SDK but is not exposed by the ingress.

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR.

…ust be set to '*'

Fixes: https://github.com/aquarist-labs/s3gw/issues/410

The `accessControlExposeHeaders` property is set to `*` now to expose all headers by default. To fix the mentioned issue adding the `X-Amz-Object-Lock-Mode` and `X-Amz-Object-Lock-Retain-Until-Date` would be sufficient, but the problem might appear again in the future, but with a different header that is processed by the AWS SDK but is not exposed by the ingress.

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev added the kind/bug Something isn't working label Mar 24, 2023
@votdev votdev added this to the v0.14.0 milestone Mar 24, 2023
@votdev votdev self-assigned this Mar 24, 2023
@votdev votdev marked this pull request as ready for review March 24, 2023 14:24
@votdev votdev requested review from jhmarina, jecluis and giubacc March 24, 2023 14:24
@votdev votdev merged commit 6696b97 into s3gw-tech:main Mar 27, 2023
@votdev votdev deleted the issue_410_ingress branch March 27, 2023 11:29
votdev added a commit to votdev/s3gw that referenced this pull request Mar 27, 2023
…ust be set to '*'

The `accessControlExposeHeaders` property is set to `*` now to expose all headers by default. To fix the mentioned issue adding the `X-Amz-Object-Lock-Mode` and `X-Amz-Object-Lock-Retain-Until-Date` would be sufficient, but the problem might appear again in the future, but with a different header that is processed by the AWS SDK but is not exposed by the ingress.

References:
- s3gw-tech/s3gw-charts#89
- https://github.com/aquarist-labs/s3gw/issues/410

Signed-off-by: Volker Theile <vtheile@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Traefik ingress is misconfigured, Access-Control-Expose-Headers must be set to *
2 participants