Remove useless getObjectRetention call … #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
votdev
added
kind/quality
…ivered by the headObject call. The problem here was that the Traefic ingress is incorrect configured in regards to the `Access-Control-Expose-Headers` header. Because of that the headers `X-Amz-Object-Lock-Mode` and `X-Amz-Object-Lock-Retain-Until-Date` where not included in the response. Signed-off-by: Volker Theile <vtheile@suse.com>
votdev
force-pushed
the
improve_headobject
branch
from
3d0ecf2 to
63c6ccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… because the information is delivered by the headObject call. The problem here was that the Traefic ingress is incorrect configured in regards to the
Access-Control-Expose-Headersheader. Because of that the headersX-Amz-Object-Lock-ModeandX-Amz-Object-Lock-Retain-Until-Datewhere not included in the response.Related to: https://github.com/aquarist-labs/s3gw/issues/410 and s3gw-tech/s3gw-charts#89
Describe your changes
Issue ticket number and link
Checklist before requesting a review