Add sender hook and rename recipient's hook functions #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: rename recipient's hook functions
refactor: add getSender function in SablierV2Lockup test: update tests accordingly
andreivladbrg
force-pushed
the
feat/add-sender-hook
branch
from
b4f9f52
to
e44a76a
Compare
smol-ninja
requested changes
Jan 10, 2024
test: correct function name
andreivladbrg
added a commit
that referenced
this pull request
Jan 21, 2024
* refactor: rename recipient's hook interface refactor: rename recipient's hook functions * feat: add hook for sender refactor: add getSender function in SablierV2Lockup test: update tests accordingly * build: include ISablierV2Sender in prepare-artifacts * test: update Precompiles bytecode * refactor: use sender address to check the caller when calling the hook test: correct function name
andreivladbrg
added a commit
that referenced
this pull request
Feb 12, 2024
* refactor: rename recipient's hook interface refactor: rename recipient's hook functions * feat: add hook for sender refactor: add getSender function in SablierV2Lockup test: update tests accordingly * build: include ISablierV2Sender in prepare-artifacts * test: update Precompiles bytecode * refactor: use sender address to check the caller when calling the hook test: correct function name
andreivladbrg
added a commit
that referenced
this pull request
Feb 15, 2024
* refactor: rename recipient's hook interface refactor: rename recipient's hook functions * feat: add hook for sender refactor: add getSender function in SablierV2Lockup test: update tests accordingly * build: include ISablierV2Sender in prepare-artifacts * test: update Precompiles bytecode * refactor: use sender address to check the caller when calling the hook test: correct function name
andreivladbrg
added a commit
that referenced
this pull request
Feb 17, 2024
* refactor: rename recipient's hook interface refactor: rename recipient's hook functions * feat: add hook for sender refactor: add getSender function in SablierV2Lockup test: update tests accordingly * build: include ISablierV2Sender in prepare-artifacts * test: update Precompiles bytecode * refactor: use sender address to check the caller when calling the hook test: correct function name
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
* refactor: rename recipient's hook interface refactor: rename recipient's hook functions * feat: add hook for sender refactor: add getSender function in SablierV2Lockup test: update tests accordingly * build: include ISablierV2Sender in prepare-artifacts * test: update Precompiles bytecode * refactor: use sender address to check the caller when calling the hook test: correct function name
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
* refactor: rename recipient's hook interface refactor: rename recipient's hook functions * feat: add hook for sender refactor: add getSender function in SablierV2Lockup test: update tests accordingly * build: include ISablierV2Sender in prepare-artifacts * test: update Precompiles bytecode * refactor: use sender address to check the caller when calling the hook test: correct function name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #742 and #736
Depends on #779 to be merged on
stagingfirst.Note: called
getSenderbefore the internal_withdrawfunction is called for security reason, in case the sender is changed when the assets are transffered.