perf: remove unchecked in for loop #788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did you create this PR, @smol-ninja? Haven't we merged #783? |
|
Me and @andreivladbrg discussed on the slack to merge PRs in the same order as they are created to avoid conflicts (and address conflicts in the PRs that are created after). So with that logic, #779 shall be merged first. That's why I had to reset the staging branch and create this new PR (or could have just rebased later) since I could not undo the merged one. |
|
Ok great thanks for confirming @smol-ninja. |
smol-ninja
force-pushed
the
perf/unchecked
branch
from
aa2e740
to
5e654ea
Compare
smol-ninja
force-pushed
the
perf/unchecked
branch
from
58695c6
to
b43cd13
Compare
|
Commits pushed directly to staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #757.