Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in test/ resulting from the audit #138

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Changes in test/ resulting from the audit #138

merged 2 commits into from
Jul 10, 2023

Conversation

IaroslavMazur
Copy link
Contributor

No description provided.

@IaroslavMazur
Copy link
Contributor Author

@PaulRBerg, see this comment that also relates to this PR

PaulRBerg
PaulRBerg reviewed Jul 10, 2023
View reviewed changes
test/Base.t.sol Outdated Show resolved Hide resolved
@PaulRBerg
revert: undo nomenclature changes
bb739fd 
test: separate out event emit tests
PaulRBerg
PaulRBerg requested changes Jul 10, 2023
View reviewed changes
Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @IaroslavMazur.

PaulRBerg
PaulRBerg approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now (after my recent commit)

@PaulRBerg
Copy link
Member

Merging - fork tests are failing because @IaroslavMazur's fork does not have an RPC_URL_MAINNET defined in the GitHub Secrets.

@PaulRBerg PaulRBerg merged commit 72f3a9d into sablier-labs:main Jul 10, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulRBerg PaulRBerg PaulRBerg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IaroslavMazur @PaulRBerg