Changes in src/ resulting from the audit #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
PaulRBerg
reviewed
Jul 10, 2023
| @@ -12,7 +12,7 @@ import { Permit2Params } from "../types/Permit2.sol"; | |||
|
|
|||
| /// @title ISablierV2ProxyTarget | |||
| /// @notice Proxy target with stateless scripts for interacting with Sablier V2, designed to be used by | |||
| /// stream senders. | |||
| /// stream senders, recipients and the recipients' approved operators. | |||
There was a problem hiding this comment.
The proxy target is designed to be used exclusively by the stream sender.
Whatever recipient-only functions (e.g., burn, ref #96) have been added only as a contingency - that is, if the proxy target ends up accidentally used by stream recipients.
But the intended design is for stream senders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.