Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create safe-ethers-lib and safe-web3-lib packages #155

Merged
merged 22 commits into from
Jan 28, 2022
Merged

Conversation

germartinez
Copy link
Member

@germartinez germartinez commented Jan 25, 2022

What it solves

  • Create new package: safe-ethers-lib (contains EthersAdapter and ethers-v5 typechain files)
  • Create new package: safe-web3-lib packages (contains Web3Adapter and web3-v1 typechain files)
  • Fixes issues with web3 and ethers dependencies

Resolves #152 and #33

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@germartinez germartinez requested a review from iamacook January 26, 2022 16:44
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy bien! Just found a few things

packages/safe-core-sdk/src/managers/contractManager.ts Outdated Show resolved Hide resolved
packages/safe-core-sdk/src/managers/contractManager.ts Outdated Show resolved Hide resolved
packages/safe-core-sdk/tests/utils/setupEthAdapter.ts Outdated Show resolved Hide resolved
packages/safe-ethers-lib/src/EthersAdapter.ts Outdated Show resolved Hide resolved
packages/safe-web3-lib/src/Web3Adapter.ts Show resolved Hide resolved
@germartinez
Copy link
Member Author

germartinez commented Jan 27, 2022

Added the changes in this PR, #158, that will be merged into this one

germartinez and others added 6 commits January 27, 2022 21:28
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@germartinez germartinez merged commit 635f9e2 into development Jan 28, 2022
@germartinez germartinez deleted the fix-deps branch January 28, 2022 16:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants