Fix web3 and ethers types #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
germartinez
commented
Jan 26, 2022
iamacook
reviewed
Jan 26, 2022
| @@ -99,15 +98,15 @@ class Web3Adapter implements EthAdapter { | |||
| return getGnosisSafeProxyFactoryContractInstance(safeVersion, proxyFactoryContract) | |||
| } | |||
|
|
|||
| getContract(address: string, abi: AbiItem[]): any { | |||
| return new this.#web3.eth.Contract(abi, address) | |||
| getContract(address: string, abi: AbiItem | AbiItem[], options?: ContractOptions): any { | |||
There was a problem hiding this comment.
Does this really return any? 👀
There was a problem hiding this comment.
It seems like the type is 'TODO:' on web3's end. It's possible to use ReturnType<typeof this.#web3.eth.Contract> to infer it I think. I'll resolve this, however, as it is not properly typed by a third party.
Remove --stream Try compiling hardhat in postinstall Restore --stream
Chore: use yarn cache in the CI script
iamacook
approved these changes
Jan 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #138
How this PR fixes it
anytype fromweb3andethersvariablesAbiItemlocal typedeterministicDeploymentproperty fromERC20Mintablecontract deployment (hardhat)