Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cowswap folder #1307

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Move cowswap folder #1307

merged 1 commit into from
Aug 30, 2024

Conversation

moisses89
Copy link
Member

Closes #1225

@moisses89 moisses89 requested a review from a team as a code owner August 28, 2024 08:15
@moisses89 moisses89 added the breaking_change Breaking change label Aug 28, 2024
@coveralls
Copy link

coveralls commented Aug 28, 2024

Pull Request Test Coverage Report for Build 10592839396

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.892%

Totals Coverage Status
Change from base Build 10592442232: 0.0%
Covered Lines: 8670
Relevant Lines: 9234

💛 - Coveralls

@@ -7,10 +7,10 @@
from eth_typing import AnyAddress, ChecksumAddress, HexStr

from safe_eth.eth import EthereumNetwork, EthereumNetworkNotSupported
from safe_eth.eth.constants import NULL_ADDRESS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which criteria should we follow in these imports? relative or absolute?

@moisses89 moisses89 merged commit d0479e8 into main Aug 30, 2024
7 checks passed
@moisses89 moisses89 deleted the move_cow_swap_folder branch August 30, 2024 08:42
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking_change Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure package folders
3 participants