Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cowswap folder #1307

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Move cowswap folder #1307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 safe_eth/cowsap/__init__.py → safe_eth/eth/clients/cowswap/__init__.py
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions safe_eth/cowsap/cow_swap_api.py → safe_eth/eth/clients/cowswap/cow_swap_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
from eth_typing import AnyAddress, ChecksumAddress, HexStr

from safe_eth.eth import EthereumNetwork, EthereumNetworkNotSupported
from safe_eth.eth.constants import NULL_ADDRESS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which criteria should we follow in these imports? relative or absolute?

from safe_eth.eth.eip712 import eip712_encode_hash
from safe_eth.util.http import prepare_http_session

from ..eth.constants import NULL_ADDRESS
from ..util.http import prepare_http_session
from .order import Order, OrderKind


Expand Down
0 safe_eth/cowsap/order.py → safe_eth/eth/clients/cowswap/order.py
View file
Open in desktop
File renamed without changes.
0 safe_eth/cowsap/tests/__init__.py → ...eth/eth/clients/cowswap/tests/__init__.py
View file
Open in desktop
File renamed without changes.
5 changes: 3 additions & 2 deletions safe_eth/cowsap/tests/test_cow_swap_api.py → ...lients/cowswap/tests/test_cow_swap_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
import pytest
from eth_account import Account

from ...eth import EthereumNetwork
from ...eth.constants import NULL_ADDRESS
from safe_eth.eth import EthereumNetwork
from safe_eth.eth.constants import NULL_ADDRESS

from .. import CowSwapAPI, Order, OrderKind


Expand Down
2 changes: 1 addition & 1 deletion safe_eth/eth/oracles/cowswap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import logging
from typing import Optional

from safe_eth.cowsap import CowSwapAPI, OrderKind
from safe_eth.eth.clients.cowswap import CowSwapAPI, OrderKind

from .. import EthereumClient, EthereumNetworkNotSupported
from .exceptions import CannotGetPriceFromOracle
Expand Down