Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gh-38453: Enhance augment method in Matrix_gf2e
This pull request modified `augment()` method defined in `matrix_gf2e_dense` to allow vectors to be augmented. See issue: #36761 Earlier it accepted only matrix of type `matrix_gf2e_dense`. I removed that dependency. Added check for vector. If vector then try to change the base ring of vector to self.base_ring and create matrix of type `matrix_gf2e_dense` from that vector Rest of the flow remains same. The parent class Matrix1 defined generic augment() method which allowed vectors to be augmented but `matrix_gf2e_dense` provides new definition of augment() and do not provide support for vectors. For consistency it would be good to have vector augmentation in this class too. Fixes #36761 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #38453 Reported by: Animesh Shree Reviewer(s): Travis Scrimshaw
- Loading branch information