-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance augment method in Matrix_gf2e #38453
Conversation
Documentation preview for this PR (built with commit 605feb4; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add a doctest showing the new behavior now works correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for losing track of this. LGTM.
Just going to wait to see if the bot comes back green with the latest develop before setting a positive review. |
This pull request modified
augment()
method defined inmatrix_gf2e_dense
to allow vectors to be augmented.See issue: #36761
Earlier it accepted only matrix of type
matrix_gf2e_dense
.I removed that dependency.
Added check for vector.
If vector then try to change the base ring of vector to self.base_ring and create matrix of type
matrix_gf2e_dense
from that vectorRest of the flow remains same.
The parent class Matrix1 defined generic augment() method which allowed vectors to be augmented but
matrix_gf2e_dense
provides new definition of augment() and do not provide support for vectors.For consistency it would be good to have vector augmentation in this class too.
Fixes #36761
📝 Checklist
⌛ Dependencies