Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken links in the doc of graph/ and numerical/ #15553

Closed
nathanncohen mannequin opened this issue Dec 20, 2013 · 8 comments
Closed

Broken links in the doc of graph/ and numerical/ #15553

nathanncohen mannequin opened this issue Dec 20, 2013 · 8 comments
Labels
c: documentation p: trivial / 5 t: bug
Milestone
sage-6.1

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Dec 20, 2013

When compiling the doc with --warn-links (pretty nice thing, by the way), some broken links appeared in the doc of graphs/ and numerical/. I fixed all I could :-)

Nathann

CC: @hivert

Component: documentation

Author: Nathann Cohen

Branch/Commit: u/ncohen/15553 @ 1d5d52a

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/15553
@nathanncohen nathanncohen mannequin added this to the sage-6.1 milestone Dec 20, 2013
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 20, 2013

Branch: u/ncohen/15553

@nathanncohen nathanncohen mannequin added the s: needs review label Dec 20, 2013
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2013

Commit: 1d5d52a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 20, 2013

Branch pushed to git repo; I updated commit sha1. New commits:

1d5d52atrac #15553: Broken links in the doc of graph/ and numerical/

@mezzarobba
Copy link
Member

comment:3

Looks good to me.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 20, 2013

comment:4

Thaaaaaaaaaaaaanks !

Nathann

@vbraun
Copy link
Member

vbraun commented Dec 21, 2013

comment:5

Fill in your reviewer names, kids ;-)

@vbraun
Copy link
Member

vbraun commented Dec 21, 2013

Reviewer: Marc Mezzarobba

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 21, 2013

comment:6

Oh, right. By the way, couldn't we have triggers automatically adding the name of the committer of the branch as the author, in case that it is empty ? I think it's rather safe. I mean, if we only set it when the field was empty and when the branch is first defined on the ticket.

Perhaps we could also script something that sets the reviewer's name (if the field is empty) using the name of the guy who sets the ticket to positive_review, but that would be a trac-only thing and I don't even know if this can be done :-)

Nathann

@vbraun vbraun closed this as completed in 9f8565f Dec 21, 2013
tscrim pushed a commit to tscrim/sage that referenced this issue Jun 1, 2023
Merge branch 'develop' into public/algebras/fp_algebras
7741424 
* develop: (101 commits)
  Updated Sage version to 6.1.beta2
  fix latex
  fix documentation
  minor typography
  Trac 13101: mark doctest as "long time"
  trac 13101 better doctest
  Trac 13101: Fix bug in enumerate_totallyreal_fields_all
  sagemath#9706: review patch.
  trac 9706: Propose new class structure
  Symbolic Chebyshev polynomials: reviewer patch
  trac 9706: Collective patch. Bugfixes, extensions, optimizations, documentation, doctests for chebyshev_T, chebyshev_U and base class for ortho polys
  Fixing Whitespace errors
  Use bash as SHELL for build/Makefile
  allow numpy arrays in list_plot, line, points
  Trac sagemath#12322: Add a doctest for the correct behavior introduced in trac sagemath#12737.
  Trac sagemath#14186 coerce_binop errors with keyword arguments
  trac sagemath#15553: Broken links in the doc of graph/ and numerical/
  Improve handling of make targets sage, csage, extcode, scripts
  Reorded all.py to match original (so fewer changes).
  Fixed minor typo in cobminat/crystals/letters.pyx.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: trivial / 5 t: bug
Projects
None yet
Milestone
sage-6.1
Development

No branches or pull requests
2 participants
@vbraun @mezzarobba