-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command "sage -tox" #30410
Comments
Branch: u/mkoeppe/command__sage__tox_ |
New commits:
|
Author: Matthias Koeppe |
Commit: |
This comment has been minimized.
This comment has been minimized.
comment:3
Instead of putting more into the (also I don't see any advantages of |
comment:4
Whatever the final interface looks like, the documentation needs to be changed as well to reflect this. In particular, this ticket depends on #30361. |
Dependencies: 30361 |
comment:5
Replying to @tobiasdiez:
Some projects are indeed using tox also for building, but I think I would like to keep it for testing only. At least for now - we can't make too many changes at the same time so that our developer community is not overwhelmed.
The difference is that And it can give a hint to install tox when it is not available. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:8
I don't think #30361 needs to be a dependency. |
comment:9
It should also be possible to add simple forwards in the
Then you can simply call |
comment:10
I also think the testing methods in bin/sage should now be removed or deprecated (or at least use tox), or not? |
comment:11
Replying to @tobiasdiez:
Good idea, will do. |
comment:12
Replying to @tobiasdiez:
For that we would first have to make tox a "standard" package. Step by step... |
comment:13
Replying to @mkoeppe:
Opened #30416 for that. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:15
Ready for review |
comment:16
Looks good to me. The only point where I'm not sure is whether the src/tox.ini file is really needed, or if it can be combined with the tox.ini in the root directory. Similarly, I'm not sure if sage -tox should always be relative to the tox config in the src folder. |
comment:17
Replying to @tobiasdiez:
Yes, I have been debating this with myself actually, but in the end I think it is important to keep src/tox.ini simple and readable -- the portability testing stuff in the root can be overwhelming to developers.
The purpose of this is to make it easy to run the tests on user code -- in the same way that |
comment:18
I've tried it on a file (with system-wide tox and python):
not sure I understand the errors from Is it possible to do only, say,
does |
comment:19
Replying to @dimpase:
Yes, |
comment:20
|
comment:21
can this be mentioned in the dev manual? then it would be a positive review. |
comment:22
OK, will do, adding to the documentation section from #30361 |
Reviewer: Dima Pasechnik |
comment:24
Thanks! |
Changed branch from u/mkoeppe/command__sage__tox_ to |
Changed commit from |
This will run tox using
src/tox.ini
.Entry point for doctesting and linting: See
./sage -tox -l -v
or(cd src && tox -l -v)
.Depends on #30408
CC: @tobiasdiez @dimpase @jhpalmieri @fchapoton
Component: doctest framework
Author: Matthias Koeppe
Branch:
eba708b
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/30410
The text was updated successfully, but these errors were encountered: