Deprecate is_FiniteField etc., make sage.rings.finite_rings a namespace package

[mkoeppe]

Part of meta-ticket #32414.

Deprecating is_FiniteField, is_PrimeFiniteField, and is_FiniteFieldElement is done for uniformity but is not needed to support modularization. #32432 shows that sage.rings.finite_rings.finite_field_base (which defines the ABC FiniteField) can be imported without pulling in implementation classes.

sage.rings.finite_rings must become a namespace package because element implementations depend on various libraries.

CC: @dimpase @kwankyu @fchapoton @tscrim

Component: refactoring

Author: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32664

[mkoeppe]

Changed dependencies from #32612 to none

[mkoeppe]

Branch: u/mkoeppe/add_sage_rings_abc_finitefield__deprecate_is_finitefield

[mkoeppe]

Commit: 8af57c4

[mkoeppe]

New commits:

8af57c4

sage.rings.finite_rings: Deprecate is_FiniteField, is_PrimeFiniteField

[mkoeppe]

Author: Matthias Koeppe

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

98b433c	sage.rings.finite_rings: Make it a namespace package
6323775	src/sage/rings/finite_rings/finite_field_constructor.py: Restore re-export of is_FiniteField
473e9d4	src/sage/rings/finite_rings/hom_finite_field.pyx: Import ABC as FiniteField_base
b82fb1e	sage.rings.finite_rings: Deprecate is_FiniteFieldElent

[sagetrac-git]

Changed commit from 8af57c4 to b82fb1e

[sagetrac-git]

Changed commit from b82fb1e to 106b22e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

106b22e

Fixups

[sagetrac-git]

Changed commit from 106b22e to de5cfad

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

de5cfad

Fixups

[sagetrac-git]

Changed commit from de5cfad to 429b372

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

429b372

Fixup: Elements of finite fields are not instances of FieldElement

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e633d8f

src/sage/crypto/mq/rijndael_gf.py: Fix imports

[sagetrac-git]

Changed commit from 429b372 to e633d8f

[sagetrac-git]

Changed commit from e633d8f to 886bc1a

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

886bc1a

src/sage/crypto/mq/rijndael_gf.py: Fix imports

[dimpase]

comment:16

shouldn't this branch be based on #34804 ?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

53ede8c	sage.rings.finite_rings: Deprecate is_FiniteField, is_PrimeFiniteField
8d4d8e5	sage.rings.finite_rings: Make it a namespace package
6ce26bc	src/sage/rings/finite_rings/finite_field_constructor.py: Restore re-export of is_FiniteField
98a5484	src/sage/rings/finite_rings/hom_finite_field.pyx: Import ABC as FiniteField_base
2e6b5ef	sage.rings.finite_rings: Deprecate is_FiniteFieldElent
3be7c97	Fixups
97a363e	Fixups
0c01403	Fixup: Elements of finite fields are not instances of FieldElement
9f4d1c4	src/sage/crypto/mq/rijndael_gf.py: Fix imports

[sagetrac-git]

Changed commit from 886bc1a to 9f4d1c4

[mkoeppe]

comment:18

Replying to Dima Pasechnik:

shouldn't this branch be based on #34804 ?

There's no relation. #34804 merges cleanly with this branch

[sagetrac-git]

Changed commit from 9f4d1c4 to 9ebadcf

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

9ebadcf

Merge tag '9.8.beta6' into t/32664/add_sage_rings_abc_finitefield__deprecate_is_finitefield

[mkoeppe]

Tests ran successfully in https://github.com/sagemath/sagetrac-mirror/actions/runs/3860089783 (before the migration).

Needs review

[mkoeppe]

Removed branch from issue description; replaced by PR #35119