Deprecate is_FiniteField etc., make sage.rings.finite_rings a namespace package
#35119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 18, 2022 13:40
…xport of is_FiniteField
…precate_is_finitefield SageMath version 9.8.beta6, Release Date: 2022-12-21
…_rings_abc_finitefield__deprecate_is_finitefield
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35119 +/- ##
===========================================
- Coverage 88.62% 88.61% -0.02%
===========================================
Files 2148 2148
Lines 398653 398659 +6
===========================================
- Hits 353308 353255 -53
- Misses 45345 45404 +59
... and 23 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
yyyyx4
reviewed
Feb 16, 2023
| @@ -1753,7 +1753,7 @@ def intmod_gap_to_sage(x): | |||
| sage: b.parent() | |||
| Ring of integers modulo 65537 | |||
| """ | |||
| from sage.rings.finite_rings.all import FiniteField | |||
| from sage.rings.finite_rings.finite_field_constructor import FiniteField | |||
There was a problem hiding this comment.
I suppose this should be finite_field_base?
There was a problem hiding this comment.
No, line 1762 uses the constructor function, not the class
yyyyx4
approved these changes
Feb 16, 2023
|
Thanks for the review! |
added 5 commits
February 19, 2023 14:28
…eprecate_is_finitefield
…eprecate_is_finitefield SageMath version 10.0.beta3, Release Date: 2023-03-02
…eprecate_is_finitefield SageMath version 10.0.beta4, Release Date: 2023-03-12
|
Documentation preview for this PR is ready! 🎉 |
vbraun
pushed a commit
that referenced
this pull request
Mar 19, 2023
…forms}: Replace imports from sage.*.all for namespace packages
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description
Fixes #34955
<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [ ] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
Depends on #35119
URL: #35106
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik, Matthias Köppe, Tobias Diez
vbraun
pushed a commit
that referenced
this pull request
Apr 1, 2023
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description - We split out `.derivations` (which uses modules) from `.maps` (which doesn't). - We separate the implementation of rational function fields (which do not need Singular for Gröbner basis calculations) from the implementation of more complicated function fields (which do). - We move some imports into methods. This is for modularization purposes: - Part of #29705 <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes #1337" --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [ ] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> - Depends on #35237 (for the feature `sage.libs.singular`) - Depends on #35119 (to preempt merge conflicts) URL: #35230 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
mkoeppe
deleted the
t/32664/add_sage_rings_abc_finitefield__deprecate_is_finitefield
branch
vbraun
pushed a commit
that referenced
this pull request
Apr 23, 2023
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description We move the `...MatrixGroup_gap` classes to separate modules named `..._gap`. This is part of: - #29705 <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes #1337" --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> - Depends on #35099 - Depends on #35119 URL: #35306 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Fixes #32664.
📝 Checklist
⌛ Dependencies