Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.{coding,groups}: Replace imports from sage.*.all for namespace packages #35099

Merged
merged 6 commits into from
Mar 19, 2023
Merged

sage.{coding,groups}: Replace imports from sage.*.all for namespace packages #35099

merged 6 commits into from
Mar 19, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 13, 2023 •
edited
Loading

📚 Description

Fixes #34948

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe requested a review from dimpase February 13, 2023 01:34
@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023 •
edited
Loading

Codecov Report

Patch coverage: 97.53% and project coverage change: -0.03 ⚠️

Comparison is base (a72bd65) 88.61% compared to head (c794aee) 88.59%.

❗ Current head c794aee differs from pull request most recent head cec7c2f. Consider uploading reports for the commit cec7c2f to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35099      +/-   ##
===========================================
- Coverage    88.61%   88.59%   -0.03%     
===========================================
  Files         2141     2140       -1     
  Lines       397945   397008     -937     
===========================================
- Hits        352656   351710     -946     
- Misses       45289    45298       +9
Impacted Files Coverage Δ
src/sage/groups/perm_gps/permgroup.py 91.06% <71.42%> (+0.01%) ⬆️
src/sage/coding/bch_code.py 97.80% <100.00%> (ø)
src/sage/coding/code_bounds.py 88.81% <100.00%> (+0.15%) ⬆️
src/sage/coding/code_constructions.py 95.37% <100.00%> (ø)
src/sage/coding/cyclic_code.py 92.00% <100.00%> (ø)
src/sage/coding/delsarte_bounds.py 86.09% <100.00%> (ø)
src/sage/coding/information_set_decoder.py 98.31% <100.00%> (+0.03%) ⬆️
src/sage/coding/linear_code.py 81.14% <100.00%> (+0.02%) ⬆️
src/sage/groups/abelian_gps/abelian_group.py 94.41% <100.00%> (+0.01%) ⬆️
...e/groups/abelian_gps/dual_abelian_group_element.py 100.00% <100.00%> (ø)
... and 7 more

... and 78 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dimpase dimpase force-pushed the t/34948/sage__coding_groups___replace_imports_from_sage___all_for_namespace_packages branch from 74a1bac to eed801f Compare February 15, 2023 00:40
@dimpase
Copy link
Member

dimpase commented Feb 15, 2023

assuming the CI passes, should be good.

dimpase
dimpase approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dimpase dimpase force-pushed the t/34948/sage__coding_groups___replace_imports_from_sage___all_for_namespace_packages branch from 81be0aa to fc2693c Compare February 18, 2023 19:25
@mkoeppe mkoeppe force-pushed the t/34948/sage__coding_groups___replace_imports_from_sage___all_for_namespace_packages branch from c794aee to cec7c2f Compare March 13, 2023 00:54
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: cec7c2f

dimpase
dimpase approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 13, 2023

Thanks!

@vbraun vbraun merged commit bcb02fe into sagemath:develop Mar 19, 2023
vbraun pushed a commit that referenced this pull request Mar 26, 2023
gh-35110: Meta-PR: Replace imports from sage.*.all for namespace pack…
80511e1 
…ages

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description
Fixes #34201

<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
- Depends on #35090
- Depends on #35098
- Depends on #35099
- Depends on #35105
- Depends on #35106
- Depends on #35107
    
URL: #35110
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
vbraun pushed a commit that referenced this pull request Apr 23, 2023
gh-35306: sage.groups.matrix_gps: Modularization fixes for imports
55ebb79 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description
We move the `...MatrixGroup_gap` classes to separate modules named
`..._gap`.

This is part of:
- #29705
<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
- Depends on #35099
- Depends on #35119
    
URL: #35306
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimpase dimpase dimpase approved these changes

@tobiasdiez tobiasdiez Awaiting requested review from tobiasdiez

Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.

sage.{coding,groups}: Replace imports from sage.*.all for namespace packages
5 participants
@mkoeppe @codecov-commenter @dimpase @vbraun @alexchandler100