Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.rings.abc.{Real,Complex}{Interval,Ball}Field; deprecate is_{Real,Complex}IntervalField #32612

Closed
mkoeppe opened this issue Oct 2, 2021 · 33 comments
Closed

sage.rings.abc.{Real,Complex}{Interval,Ball}Field; deprecate is_{Real,Complex}IntervalField #32612

mkoeppe opened this issue Oct 2, 2021 · 33 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 2, 2021

This ticket is for the parent classes.

The is_... methods for element classes will be taken care of in #24525.

Depends on #32566
Depends on #32610
Depends on #32606

CC: @kliem @tscrim

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 124f213

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32612
@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 2, 2021
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 4, 2021

Dependencies: #32566

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 4, 2021

Branch: u/mkoeppe/sage_rings_abc__real_complex__interval_ball_field__deprecate_is__real_complex_intervalfield

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Commit: a8432f9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

7ce73e6git grep -l -E 'is_(Real|Complex)(Interval|Ball)Field' | xargs sed -E -i.bak 's/^from sage[.]rings.*import is_((Real|Complex)(Interval|Ball)Field) *$/import sage.rings.abc/;s/is_((Real|Complex)(Interval|Ball)Field)[(]([^)]*)[)]/isinstance(\4, sage.rings.abc.\1)/g;'
a8432f9is_{Real,Complex}{Ball,Interval}Field: Undo automatic edits

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 4, 2021

Changed dependencies from #32566 to #32566, #32610

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

49e75d1Merge #32566
c7aa947sage.probability: Fix up replacement of is_{Real,Complex}[Double]Field
b8691ccsrc/sage/rings/number_field/number_field_element.pyx: Remove unused import
abbe26dsrc/sage/modules/free_module.py: Remove another use of is_... functions
65e9b98src/sage/rings/polynomial/polynomial_singular_interface.py: Fixup
a00d97asrc/sage/rings/number_field/number_field.py: Fixup
fa79b10Add missing imports of sage.rings.abc
94fd9c5is_{Real,Complex}[Double]Field: In doctests, add deprecation warning to expected output
dd7e96csrc/sage/schemes/elliptic_curves/ell_number_field.py: Add missing import
1e5a6aaMerge #32610

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Changed commit from a8432f9 to 1e5a6aa

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 4, 2021

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

be1db02src/sage/rings/abc.pxd: Add cdef class RealIntervalField

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Changed commit from 1e5a6aa to be1db02

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Changed commit from be1db02 to 85a6a0b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

13607cbsrc/sage/dynamics/arithmetic_dynamics/projective_ds.py: Remove unused import
85a6a0bMerge #32610

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Changed commit from 85a6a0b to fc039f1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

271e044src/sage/rings/real_interval_absolute.pyx: Fix imports
fc039f1src/sage/symbolic/ring.pyx: Fix imports

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

19ac6fdsrc/sage/rings/complex_interval_field.py: Fixup deprecation warning in doctest output

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Changed commit from fc039f1 to 19ac6fd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

f31deb3src/sage/rings/qqbar.py: Remove unused import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2021

Changed commit from 19ac6fd to f31deb3

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 4, 2021

comment:13

Green bot, ready for review (the deprecation_number plugin failure is complaining about code from the #32610 ticket)

@tscrim
Copy link
Collaborator

tscrim commented Oct 4, 2021

comment:14

There is no deprecation for is_RealIntervalField() AFAICS. Otherwise LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 4, 2021

comment:15

The whole module sage.rings.real_interval_field, which provides is_RealIntervalField, is already deprecated

@tscrim
Copy link
Collaborator

tscrim commented Oct 4, 2021

comment:16

Okay, then LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Oct 4, 2021

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 4, 2021

comment:17

Thanks!

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 8, 2021

Changed commit from f31deb3 to 362f5c0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 8, 2021

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

b3290edMerge #32566
9e74b6asage.rings.abc: Add IntegerModRing, Order; use them in sage.matrix, sage.modules
8ef2b35sage.structure, sage.rings, sage.matrix: Use sage.rings.abc for IntegerModRing
335cd3eReplace all uses of is_IntegerModRing by isinstance(..., sage.rings.abc.IntegerModRing)
f596395sage.rings.finite_rings.integer_mod_ring: Fixup
af06e5bis_IntegerModRing: Deprecate
362f5c0Merge branch 't/32606/replace_is_integermodring_by_isinstance_with_new_class_sage_rings_abc_integermodring' into t/32612/sage_rings_abc__real_complex__interval_ball_field__deprecate_is__real_complex_intervalfield

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 8, 2021

Changed dependencies from #32566, #32610 to #32566, #32610, #32606

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 8, 2021

comment:19

Merged #32606 to resolve merge conflict

@vbraun
Copy link
Member

vbraun commented Oct 13, 2021

comment:20

Merge conflict

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 13, 2021

Changed commit from 362f5c0 to 124f213

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 13, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

1b0a5absrc/sage/modules/vector_space_morphism.py: Do not fail if sage.symbol is not present
83b5038src/sage/modules/free_module_element.pyx: Move import from sage.misc.derivative into method
acca6c2src/sage/matrix/matrix2.pyx: Move import from sage.misc.derivative into method
907b57cMerge #32593
355dbcbMerge #32606
fb56937Merge tag '9.5.beta3' into t/32610/deprecate_is_realfield__is_complexfield__is_realdoublefield__is_complexdoublefield
8cc3500src/sage/rings/polynomial/polynomial_singular_interface.py: Fixup merge
124f213Merge #32610

@vbraun
Copy link
Member

vbraun commented Oct 19, 2021

Changed branch from u/mkoeppe/sage_rings_abc__real_complex__interval_ball_field__deprecate_is__real_complex_intervalfield to 124f213

@vbraun vbraun closed this as completed in e0baa96 Oct 19, 2021
@tobiasdiez tobiasdiez mentioned this issue Dec 19, 2021
Closed
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32612
168fa62
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32612
4afbcfc
mkoeppe added a commit to mkoeppe/sage that referenced this issue Sep 21, 2023
@mkoeppe
src/sage/rings/complex_interval_field.py: Remove function deprecated in
0b4b4fe 
sagemath#32612 (2021)
vbraun pushed a commit to vbraun/sage that referenced this issue Sep 23, 2023
sagemathgh-36307: sage.rings: Remove code deprecated in sagemath#23204
9ea5127 
, sagemath#24483, sagemath#24371, sagemath#24511, sagemath#25848, sagemath#26105, sagemath#28481, sagemath#29010, sagemath#29412, sagemath#30332, sagemath#30372, sagemath#31345, sagemath#32375, sagemath#32606, sagemath#32610, sagemath#32612, sagemath#32641, sagemath#32660, sagemath#32750, sagemath#32869, sagemath#33602

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36307
Reported by: Matthias Köppe
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @mkoeppe