Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split off sage.rings.number_field.homset from sage.rings.number_field.morphism #29010

Closed
pjbruin opened this issue Jan 14, 2020 · 9 comments
Closed

Split off sage.rings.number_field.homset from sage.rings.number_field.morphism #29010

pjbruin opened this issue Jan 14, 2020 · 9 comments
Labels
c: number fields p: minor / 4
Milestone
sage-9.1

Comments

@pjbruin
Copy link
Contributor

pjbruin commented Jan 14, 2020

The module sage.rings.number_field.morphism contains classes for homsets as well as homomorphisms. It would be good to split off the homsets as a new module similar to sage.rings.homset. One advantage is that this will make the patch for #28869 more readable.

Component: number fields

Author: Peter Bruin

Branch/Commit: fa2a465

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29010
@pjbruin pjbruin added this to the sage-9.1 milestone Jan 14, 2020
@pjbruin
Copy link
Contributor Author

pjbruin commented Jan 14, 2020

Branch: u/pbruin/29010-number_field_homset

@pjbruin
Copy link
Contributor Author

pjbruin commented Jan 14, 2020

Commit: 1a66fed

@tscrim
Copy link
Collaborator

tscrim commented Jan 14, 2020

comment:2

LGTM except I think we should have a deprecation redirect (which you can do with a lazy_import IIRC).

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

fa2a465Trac 29010: add lazy import with deprecation warning for moved classes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2020

Changed commit from 1a66fed to fa2a465

@pjbruin
Copy link
Contributor Author

pjbruin commented Jan 15, 2020

comment:4

Replying to @tscrim:

LGTM except I think we should have a deprecation redirect (which you can do with a lazy_import IIRC).

Done, thanks for the hint.

@tscrim
Copy link
Collaborator

tscrim commented Jan 15, 2020

comment:5

Thank you.

@tscrim
Copy link
Collaborator

tscrim commented Jan 15, 2020

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jan 20, 2020

Changed branch from u/pbruin/29010-number_field_homset to fa2a465

@vbraun vbraun closed this as completed in 64438ce Jan 20, 2020
@sagetrac-jvlangen sagetrac-jvlangen mannequin mentioned this issue Jan 31, 2020
Closed
mkoeppe added a commit to mkoeppe/sage that referenced this issue Sep 21, 2023
@mkoeppe
src/sage/rings/number_field/morphism.py: Remove import deprecated in s…
c50325c 
…agemath#29010 (2020)
vbraun pushed a commit to vbraun/sage that referenced this issue Sep 23, 2023
sagemathgh-36307: sage.rings: Remove code deprecated in sagemath#23204
9ea5127 
, sagemath#24483, sagemath#24371, sagemath#24511, sagemath#25848, sagemath#26105, sagemath#28481, sagemath#29010, sagemath#29412, sagemath#30332, sagemath#30372, sagemath#31345, sagemath#32375, sagemath#32606, sagemath#32610, sagemath#32612, sagemath#32641, sagemath#32660, sagemath#32750, sagemath#32869, sagemath#33602

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36307
Reported by: Matthias Köppe
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: number fields p: minor / 4
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @pjbruin