Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate cotangent methods named "cotan" to "cot" #29412

Closed
DaveWitteMorris opened this issue Mar 26, 2020 · 12 comments
Closed

Deprecate cotangent methods named "cotan" to "cot" #29412

DaveWitteMorris opened this issue Mar 26, 2020 · 12 comments
Labels
c: numerical p: minor / 4 t: enhancement
Milestone
sage-9.2

Comments

@DaveWitteMorris
Copy link
Member

Most of sage uses cot for the cotangent function 1/tan(x), but the classes ComplexNumber and MPComplexNumber have methods that are called cotan, instead. To eliminate a bug caused by this inconsistency, ticket #29409 renames these methods to cot.

For backward compatibility, ticket #29409 defines cotan as an alias for cot in these two classes. This ticket deprecates those aliases.

FWIW, Maple uses cot and Mathematica uses Cot.

Depends on #29409

Component: numerical

Keywords: cotangent, complex

Author: Dave Morris

Branch/Commit: b78b409

Reviewer: Markus Wageringel

Issue created by migration from https://trac.sagemath.org/ticket/29412
@DaveWitteMorris DaveWitteMorris added this to the sage-9.1 milestone Mar 26, 2020
@DaveWitteMorris
Copy link
Member Author

Branch: public/29412

@DaveWitteMorris
Copy link
Member Author

New commits:

9b59968change cotan to tan
6259014deprecate cotan

@DaveWitteMorris
Copy link
Member Author

Commit: 6259014

@DaveWitteMorris
Copy link
Member Author

Author: Dave Morris

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

b941d30include ticket number in comments
b78b409Merge ticket #29409

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2020

Changed commit from 6259014 to b78b409

@DaveWitteMorris
Copy link
Member Author

comment:5

To avoid a merge conflict, I merged with #29409, but that makes no changes to the files in this branch. (The lines that changed in #29409 are exactly the ones that this ticket replaces with deprecations.)

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 14, 2020

comment:6

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 14, 2020
@mwageringel
Copy link

comment:7

This looks good to me.

@mwageringel
Copy link

Reviewer: Markus Wageringel

@DaveWitteMorris
Copy link
Member Author

comment:8

Thanks for the review!

@vbraun
Copy link
Member

vbraun commented Aug 23, 2020

Changed branch from public/29412 to b78b409

@vbraun vbraun closed this as completed in c051d99 Aug 23, 2020
mkoeppe added a commit to mkoeppe/sage that referenced this issue Sep 21, 2023
@mkoeppe
src/sage/rings/complex_{mpc,mpfr}.pyx: Remove method aliases deprecat…
1b12b5f 
…ed in sagemath#29412 (2020)
vbraun pushed a commit to vbraun/sage that referenced this issue Sep 23, 2023
sagemathgh-36307: sage.rings: Remove code deprecated in sagemath#23204
9ea5127 
, sagemath#24483, sagemath#24371, sagemath#24511, sagemath#25848, sagemath#26105, sagemath#28481, sagemath#29010, sagemath#29412, sagemath#30332, sagemath#30372, sagemath#31345, sagemath#32375, sagemath#32606, sagemath#32610, sagemath#32612, sagemath#32641, sagemath#32660, sagemath#32750, sagemath#32869, sagemath#33602

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36307
Reported by: Matthias Köppe
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: numerical p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
4 participants
@vbraun @mkoeppe @mwageringel @DaveWitteMorris