Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and activate W391 in pyx files #34929

Closed
fchapoton opened this issue Jan 22, 2023 · 6 comments · Fixed by #35091
Closed

fix and activate W391 in pyx files #34929

fchapoton opened this issue Jan 22, 2023 · 6 comments · Fixed by #35091
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-10.0

Comments

@fchapoton
Copy link
Contributor

fchapoton commented Jan 22, 2023 •
edited by mkoeppe
Loading

W391 blank line at end of file

Component: refactoring

Author: Frédéric Chapoton

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34929
@fchapoton fchapoton added this to the sage-9.8 milestone Jan 22, 2023
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34929

@fchapoton
Copy link
Contributor Author

New commits:

81bec94fix and activate W391 in cython files

@fchapoton
Copy link
Contributor Author

Commit: 81bec94

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 22, 2023

Reviewer: Matthias Koeppe

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Feb 11, 2023
@vbraun
Copy link
Member

vbraun commented Feb 12, 2023

Merge conflict, please open GitHub PR to fix

@fchapoton fchapoton mentioned this issue Feb 12, 2023
Merged
2 tasks
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 12, 2023

Removed branch from issue description; replaced by PR #35091

vbraun pushed a commit that referenced this issue Mar 19, 2023
gh-35091: fix and activate W391 in pyx files
b220333 
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description


Fixes #34929

Activate the check for pycodestyle W391 in pyx files

<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->
    
URL: #35091
Reported by: Frédéric Chapoton
Reviewer(s): Edgar Costa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging a pull request may close this issue.

fix and activate W391 in pyx files fchapoton/sage
3 participants
@vbraun @fchapoton @mkoeppe