Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and activate W391 in pyx files #35091

Merged
merged 2 commits into from
Mar 19, 2023
Merged

Conversation

fchapoton
Copy link
Contributor

📚 Description

Fixes #34929

Activate the check for pycodestyle W391 in pyx files

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.

⌛ Dependencies

@codecov-commenter
Copy link

Codecov Report

Base: 88.60% // Head: 88.59% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (71925b9) compared to base (c000c95).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35091      +/-   ##
===========================================
- Coverage    88.60%   88.59%   -0.01%     
===========================================
  Files         2136     2136              
  Lines       396142   396142              
===========================================
- Hits        350990   350972      -18     
- Misses       45152    45170      +18     
Impacted Files Coverage Δ
src/sage/interfaces/qsieve.py 71.30% <0.00%> (-2.61%) ⬇️
src/sage/graphs/generators/random.py 91.26% <0.00%> (-1.37%) ⬇️
src/sage/modular/hecke/algebra.py 94.65% <0.00%> (-1.07%) ⬇️
src/sage/schemes/elliptic_curves/cardinality.py 86.61% <0.00%> (-0.79%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.88% <0.00%> (-0.79%) ⬇️
src/sage/groups/generic.py 88.34% <0.00%> (-0.68%) ⬇️
...sage/geometry/hyperbolic_space/hyperbolic_model.py 88.95% <0.00%> (-0.62%) ⬇️
src/sage/sets/integer_range.py 91.41% <0.00%> (-0.51%) ⬇️
src/sage/cpython/_py2_random.py 76.03% <0.00%> (-0.42%) ⬇️
src/sage/combinat/constellation.py 91.18% <0.00%> (-0.41%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@edgarcosta
Copy link
Member

LGTM

@edgarcosta edgarcosta self-requested a review February 13, 2023 17:01
@vbraun vbraun merged commit b220333 into sagemath:develop Mar 19, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 19, 2023
@fchapoton fchapoton deleted the ticket34929 branch July 16, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix and activate W391 in pyx files
5 participants