SetSystem: Minor change to accommodate set input
#38056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the code cleaner in multiple places.
|
Documentation preview for this PR (built with commit 79143df; changes) is ready! 🎉 |
SageMath version 10.4.beta7, Release Date: 2024-05-25
gmou3
changed the title
SetSystem: Minor change to accomodate set inputSetSystem: Minor change to accommodate set input
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 27, 2024
This change makes the code cleaner in multiple places. The PR also includes some docstring edits in `set_system.pyx`. ### ⌛ Dependencies - Depends on sagemath#37930 and sagemath#38027 URL: sagemath#38056 Reported by: gmou3 Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 29, 2024
This change makes the code cleaner in multiple places. The PR also includes some docstring edits in `set_system.pyx`. ### ⌛ Dependencies - Depends on sagemath#37930 and sagemath#38027 URL: sagemath#38056 Reported by: gmou3 Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 5, 2024
Especially for internal functions (starting with `_`). The PR includes many changes, most of which are algorithmically inconsequential (simple type declarations and docstring edits). Careful review is mostly needed for commit `f0fd595`, where some extra type castings are done within basic `matroid` functions. ### ⌛ Dependencies - Depends on sagemath#38056. URL: sagemath#38057 Reported by: gmou3 Reviewer(s): gmou3, Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 8, 2024
Especially for internal functions (starting with `_`). The PR includes many changes, most of which are algorithmically inconsequential (simple type declarations and docstring edits). Careful review is mostly needed for commit `f0fd595`, where some extra type castings are done within basic `matroid` functions. ### ⌛ Dependencies - Depends on sagemath#38056. URL: sagemath#38057 Reported by: gmou3 Reviewer(s): gmou3, Matthias Köppe, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the code cleaner in multiple places.
The PR also includes some docstring edits in
set_system.pyx.⌛ Dependencies
CircuitsMatroid#37930 and Work onFlatsMatroid#38027