matroids: Declare function input and return types
#38057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type_declarations
Especially for internal functions. This part (1/2) includes algorithmically neutral or positive changes.
This part contains some algorithmically questionable changes in `matroid.pyx`. Needs careful review.
Make the thing compile and pass the tests.
|
Documentation preview for this PR (built with commit c3977dd; changes) is ready! 🎉 |
|
there are test failures |
mkoeppe
reviewed
May 27, 2024
mkoeppe
reviewed
May 27, 2024
mkoeppe
reviewed
May 27, 2024
mkoeppe
reviewed
May 29, 2024
mkoeppe
reviewed
May 29, 2024
Deprecate `in/dependent_r_sets`
mkoeppe
reviewed
Jun 4, 2024
mkoeppe
reviewed
Jun 4, 2024
As suggested by mkoeppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 5, 2024
Especially for internal functions (starting with `_`). The PR includes many changes, most of which are algorithmically inconsequential (simple type declarations and docstring edits). Careful review is mostly needed for commit `f0fd595`, where some extra type castings are done within basic `matroid` functions. ### ⌛ Dependencies - Depends on sagemath#38056. URL: sagemath#38057 Reported by: gmou3 Reviewer(s): gmou3, Matthias Köppe, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially for internal functions (starting with
_).The PR includes many changes, most of which are algorithmically inconsequential (simple type declarations and docstring edits).
Careful review is mostly needed for commit
f0fd595, where some extra type castings are done within basicmatroidfunctions.⌛ Dependencies
SetSystem: Minor change to accommodate set input #38056.