Homogenise .log() api across implementations of finite field elements
#38359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ements Mimick Lorenz Panny's code from sagemath#37329
…lements The argument is unused. It's only there for coherence with the rest of the implementations.
|
Documentation preview for this PR (built with commit 26b8ab2; changes) is ready! 🎉 |
yyyyx4
approved these changes
Jul 16, 2024
mkoeppe
changed the title
.log() api across implementations of finite field elements
yyyyx4
added a commit
to yyyyx4/sage
that referenced
this pull request
Jul 17, 2024
yyyyx4
added a commit
to yyyyx4/sage
that referenced
this pull request
Aug 1, 2024
yyyyx4
added a commit
to yyyyx4/sage
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38350 by adding
order=andcheck=arguments to the.log()method of finite field elements, under all implementations.element_pari_ffelt.pyx: done by @yyyyx4 in add optional order= argument to .log() method for PARI finite-field elements #37329.element_ntl_gf2e.pyx: if provided, does not computebase_order.element_givaro.pyx: if provided, passesorderto the underlyingdiscrete_logcall.integer_mod.pyx: the argument is discarded (unlesscheck=True, in which case the order is checked).📝 Checklist
⌛ Dependencies