Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogenise .log() api across implementations of finite field elements #38359

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Homogenise .log() api across implementations of finite field elements #38359

merged 6 commits into from
Jul 24, 2024

Commits on Jul 13, 2024

  1. add optional order= argument to .log() method for NTL finite-field el… 

    …ements

Mimick Lorenz Panny's code from sagemath#37329
    @AZ-0
    AZ-0 committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    b10746d View commit details
    Browse the repository at this point in the history

  2. add optional order= argument to .log() method for Givaro finite-field… 

    … elements
    @AZ-0
    AZ-0 committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    06e5e86 View commit details
    Browse the repository at this point in the history

  3. add optional order= argument to .log() method for modn finite-field e… 

    …lements

The argument is unused. It's only there for coherence with the rest of the implementations.
    @AZ-0
    AZ-0 committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    e55bfbc View commit details
    Browse the repository at this point in the history

  4. add optional check= argument to .log() method for modn finite-field e… 

    …lements
    @AZ-0
    AZ-0 committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    fe1923d View commit details
    Browse the repository at this point in the history

  5. add tests for check=True in element_ntl_gf2e.pyx and integer_mod.pyx

    @AZ-0
    AZ-0 committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    14de61e View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. remove whitespaces from blank lines

    @AZ-0
    AZ-0 committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    26b8ab2 View commit details
    Browse the repository at this point in the history