Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add access to printlevel in libsingular #38365

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

fchapoton
Copy link
Contributor

this is adding and using a simplified access to libsingular printlevel state variable

useful in turning down the comments easily

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@fchapoton
Copy link
Contributor Author

maybe we should also create a set_printlevel method too ?

Copy link

github-actions bot commented Jul 14, 2024

Documentation preview for this PR (built with commit 1a387d8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 16, 2024

maybe we should also create a set_printlevel method too ?

Good idea.

@fchapoton
Copy link
Contributor Author

done and used

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 2, 2024
    
this is adding and using a simplified access to libsingular
``printlevel`` state variable

useful in turning down the comments easily

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38365
Reported by: Frédéric Chapoton
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit cbe23c7 into sagemath:develop Aug 3, 2024
19 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Aug 3, 2024
@fchapoton fchapoton deleted the printlevel_for_libsingular branch August 4, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants