-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert two methods to libsingular in affine subscheme #38367
Open
fchapoton
wants to merge
4
commits into
sagemath:develop
Choose a base branch
from
fchapoton:libsingular_affine_subscheme
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
convert two methods to libsingular in affine subscheme #38367
fchapoton
wants to merge
4
commits into
sagemath:develop
from
fchapoton:libsingular_affine_subscheme
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchapoton
force-pushed
the
libsingular_affine_subscheme
branch
from
August 4, 2024 11:36
dc6e9ba
to
fcf98f1
Compare
fchapoton
force-pushed
the
libsingular_affine_subscheme
branch
from
August 9, 2024 06:22
fcf98f1
to
32362ac
Compare
Documentation preview for this PR (built with commit 375667a; changes) is ready! π |
not clear to me how to avoid the remaining verbosity... |
so there is a failing doctest, damn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is using #38365 to convert some methods to use
libsingular
π Checklist
β Dependencies
#38365