Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container does not sync sakuli project - just test suite #66

Closed
5 tasks done
svettwer opened this issue Sep 11, 2020 · 0 comments
Closed
5 tasks done

Container does not sync sakuli project - just test suite #66

svettwer opened this issue Sep 11, 2020 · 0 comments
Assignees
@svettwer

Comments

@svettwer
Copy link
Contributor

svettwer commented Sep 11, 2020 •
edited
Loading

While enabling typescript in the container, we introduced a sakuli execution directory where we link node_modules into and sync it with the test suite. As the project might contain config in sakuli.properties, which is currently not synced, global config (e.g. enabling forwarding) is not considered during execution.

  • Ensure sakuli execution dir contains always the whole project and not only the suite
  • review git clone functionality concerning execution dir
  • remove default test case as it is not used by anyone and always shipped with no use case
  • remove demo case deletion from s2i assembly script
  • ensure s2i functionality is not broken even, if a project is given in SAKULI_TESTSUITE / SAKULI_CONTEXT_DIR
@svettwer svettwer self-assigned this Sep 11, 2020
svettwer added a commit that referenced this issue Sep 11, 2020
@svettwer
(#66)altered tests to use SAKULI_TEST_SUITE correctly
04363ea
svettwer added a commit that referenced this issue Sep 11, 2020
@svettwer
(#66) Removed demo test case
d55e9ee
svettwer added a commit that referenced this issue Sep 14, 2020
@svettwer
(#66) Fixed test suite / test project misconception
78e08bf
svettwer added a commit that referenced this issue Sep 14, 2020
@svettwer
(#66) Unlink node_modules in case of container reuse
4f60a73
svettwer added a commit that referenced this issue Sep 14, 2020
@svettwer
(#66) Added regression test for container exit code
485f487
svettwer added a commit that referenced this issue Sep 14, 2020
@svettwer
(#66) Check logs to ensure test case *really* went well
0776e95
svettwer added a commit that referenced this issue Sep 14, 2020
@svettwer
(#66) Removed logs check due to insufficient permissions on travis agent
23f0511
svettwer added a commit that referenced this issue Sep 14, 2020
@svettwer
(#66) Added test to start sakuli container with other commands than n…
80c30d5 
…pm t
svettwer added a commit that referenced this issue Sep 14, 2020
@svettwer
(#66) [cosmetic] only unlink if link was created previously => suppre…
af526e2 
…ssing ugly error message
svettwer added a commit to sakuli/sakuli-openshift-s2i that referenced this issue Sep 14, 2020
@svettwer
(sakuli/sakuli-docker#66) removed demo suite removal => not required …
d730669 
…anymore
svettwer added a commit to sakuli/sakuli-openshift-s2i that referenced this issue Sep 14, 2020
@svettwer
Merge branch 'develop' into fix/(sakuli/sakuli-docker#66)/sync-project
f542cd6
svettwer added a commit to sakuli/sakuli-openshift-s2i that referenced this issue Sep 14, 2020
@svettwer
(sakuli/sakuli-docker#66) corrected test to use suite instead of project
7a27f63
svettwer added a commit to sakuli/sakuli-openshift-s2i that referenced this issue Sep 16, 2020
@svettwer
(sakuli/sakuli-docker#66) test suite as well as project
0a37ae9
svettwer added a commit to sakuli/sakuli-openshift-s2i that referenced this issue Sep 16, 2020
@svettwer
Merge pull request #14 from sakuli/fix/(sakuli/sakuli-docker#66)/sync…
3b04b31 
…-project

Fix/(sakuli/sakuli docker#66)/sync project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svettwer svettwer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@svettwer