Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/(sakuli/sakuli docker#66)/sync project #14

Merged
merged 5 commits into from
Sep 16, 2020
Merged

Fix/(sakuli/sakuli docker#66)/sync project #14

merged 5 commits into from
Sep 16, 2020

Conversation

svettwer
Copy link
Contributor

No description provided.

@cliffle cliffle self-assigned this Sep 15, 2020
cliffle
cliffle reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@cliffle cliffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a test where a sakuli project is used instead of only testing it with a sakuli test suite

@cliffle cliffle assigned svettwer and unassigned cliffle Sep 15, 2020
@svettwer svettwer assigned cliffle and unassigned svettwer Sep 16, 2020
cliffle
cliffle approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@cliffle cliffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cliffle cliffle assigned svettwer and unassigned cliffle Sep 16, 2020
@svettwer svettwer merged commit 3b04b31 into develop Sep 16, 2020
@svettwer svettwer deleted the fix/(sakuli/sakuli-docker#66)/sync-project branch September 16, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliffle cliffle cliffle approved these changes

Assignees

@svettwer svettwer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svettwer @cliffle