すべてを含んだ zip を作成しないようにする (#514 の軽減策) #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryzplus
reviewed
Oct 28, 2018
| @@ -91,7 +91,6 @@ More information: https://github.com/sakura-editor/sakura/issues/6 | |||
| 5. 自分がダウンロードしたいものをクリックしてダウンロードします。 | |||
| - (ユーザー用) 末尾に `Exe` がついてるのが実行ファイルのセットです。 | |||
| - (ユーザー用) 末尾に `Installer` がついてるのがインストーラのセットです。 | |||
| - (すべて欲しい人向け) `All` がついてるのがバイナリ、インストーラ、ビルドログ、アセンブラ出力のフルセットです。 | |||
There was a problem hiding this comment.
allを作らないのは暫定じゃないんですか？
他の人の意見もあると思いますが、「一時停止中」で残しておいていいような気がします。
zipArtifacts.bat
Outdated
| @@ -146,16 +146,12 @@ set WORKDIR_LOG=%WORKDIR%\Log | |||
| set WORKDIR_EXE=%WORKDIR%\EXE | |||
| set WORKDIR_INST=%WORKDIR%\Installer | |||
| set WORKDIR_ASM=%BASENAME%-Asm | |||
| set OUTFILE=%BASENAME%-All.zip | |||
There was a problem hiding this comment.
この定義を残したままでも all を出力しない、は実現できると思います。
zipArtifacts.bat
Outdated
| set OUTFILE_LOG=%BASENAME%-Log.zip | ||
| set OUTFILE_ASM=%BASENAME%-Asm.zip | ||
| set OUTFILE_INST=%BASENAME%-Installer.zip | ||
| set OUTFILE_EXE=%BASENAME%-Exe.zip | ||
|
|
||
| @rem cleanup for local testing | ||
| if exist "%OUTFILE%" ( | ||
| del %OUTFILE% | ||
| ) |
zipArtifacts.bat
Outdated
| call %ZIP_CMD% %OUTFILE_LOG% %WORKDIR_LOG% | ||
|
|
||
| @rem copy text files for warning after zipping %OUTFILE% because %WORKDIR% is the parent directory of %WORKDIR_EXE% and %WORKDIR_INST%. |
There was a problem hiding this comment.
フォルダ構造を変えるわけではないのでコメントは残しておいていい気がします。
zipArtifacts.bat
Outdated
| @@ -242,11 +238,8 @@ copy /Y installer\warning.txt %WORKDIR%\ | |||
| if "%ALPHA%" == "1" ( | |||
| copy /Y installer\warning-alpha.txt %WORKDIR%\ | |||
| ) | |||
| call %ZIP_CMD% %OUTFILE% %WORKDIR% | |||
|
|
|||
There was a problem hiding this comment.
アーティファクトを作っているのはこの一文なので、
ここをコメントアウトすればallは回収されないと思います。
枠組みとして残しておいて、GitHub Releaseへの登録のときだけ使う、みたいなことできないかな、と思いました。
|
appveyor.yml でアップロードするartifactsを限定するやり方もあります。 |
m-tmatma
force-pushed
the
feature/exclude-all-artifacts
branch
3 times, most recently
from
39674f5 to
7320433
Compare
m-tmatma
force-pushed
the
feature/exclude-all-artifacts
branch
from
7320433 to
11fdce2
Compare
|
修正しました。 |
berryzplus
approved these changes
Oct 28, 2018
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
…l-artifacts すべてを含んだ zip を作成しないようにする (sakura-editor#514 の軽減策)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
すべてを含んだ zip を作成しないようにする (#514 の軽減策)