Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing compile option of test1.exe on MinGW platform. #783

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

ds14050
Copy link
Contributor

@ds14050 ds14050 commented Feb 5, 2019

Fix #782 issue「MinGW の Debug で CNativeW.Clear のテストに失敗する」

エディタ本体のコンパイルオプションとテストプログラムのコンパイルオプションの不一致を修正してプログラムの暴走を止めます。

pull #591 「Build and run tests on MinGW environment.」の作業漏れです。

@ds14050
Copy link
Contributor Author

ds14050 commented Feb 5, 2019

誤) test1.exe
正) tests1.exe (tests*.exe)

@m-tmatma
Copy link
Member

m-tmatma commented Feb 5, 2019

NDEBUG は自動的に定義されるらしい
https://stackoverflow.com/questions/34302265/does-cmake-build-type-release-imply-dndebug

@m-tmatma m-tmatma added this to the next release milestone Feb 5, 2019
@ds14050
Copy link
Contributor Author

ds14050 commented Feb 5, 2019

CMake のプリセットを調べて表にした方がいます>「CMakeのコンパイラ向けオプションを調べてみた - 座敷牢日誌

ここでやっているのは所詮「# Hacks to reuse compiled editor objects.」なので定義されている NDEBUG には触れませんでした。

@ds14050 ds14050 merged commit f001bb3 into sakura-editor:master Feb 5, 2019
@ds14050 ds14050 deleted the fix_mingwtest_compileoption branch February 16, 2019 09:05
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants