Fix pasting float number into datagrid (#4335)

saleor · Oct 19, 2023 · 3f6dcfa · 3f6dcfa
1 parent 466914f
commit 3f6dcfa
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/.changeset/stale-shirts-lie.md b/.changeset/stale-shirts-lie.md
@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": patch
+---
+
+Fix pasting float number into datagrid
diff --git a/src/components/Datagrid/customCells/NumberCell.tsx b/src/components/Datagrid/customCells/NumberCell.tsx
@@ -14,13 +14,15 @@ export interface NumberCellProps {
   readonly kind: "number-cell";
   readonly value: number | typeof numberCellEmptyValue;
   readonly options?: {
-    format: "number" | "percent";
+    format?: "number" | "percent";
+    hasFloatingPoint?: boolean;
   };
 }
 
 export type NumberCell = CustomCell<NumberCellProps>;
 
 const onlyDigitsRegExp = /^\d+$/;
+const flaotingPointDigits = /^[0-9]+[.,]?[0-9]+$/;
 
 const NumberCellEdit: ReturnType<ProvideEditorCallback<NumberCell>> = ({
   value: cell,
@@ -80,7 +82,10 @@ export const numberCellRenderer = (
     }),
   }),
   onPaste: (value, data) => {
-    if (!onlyDigitsRegExp.test(value)) {
+    const testRegExp = data.options?.hasFloatingPoint
+      ? flaotingPointDigits
+      : onlyDigitsRegExp;
+    if (!testRegExp.test(value)) {
       return undefined;
     }
 

diff --git a/src/products/components/ProductVariants/utils.tsx b/src/products/components/ProductVariants/utils.tsx
@@ -149,7 +149,7 @@ export function getData({
 
     if (!available) {
       return {
-        ...numberCell(numberCellEmptyValue),
+        ...numberCell(numberCellEmptyValue, { hasFloatingPoint: true }),
         readonly: false,
         allowOverlay: false,
       };