add_voucher_used-info#3972 #4161

itsjainrishi · 2023-09-04T04:06:42Z

Screenshots

Before

After

Pull Request Checklist

This code contains UI changes
All visible strings are translated with proper context including data-formatting
Attributes data-test-id are added for new elements
The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
Your code works with the latest stable version of the core
I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

CONTAINERS=2

changeset-bot · 2023-09-04T04:06:45Z

⚠️ No Changeset found

Latest commit: e40e6de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CLAassistant · 2023-09-04T04:06:47Z

All committers have signed the CLA.

CLAassistant · 2023-09-04T04:06:47Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

poulch · 2023-09-04T06:22:19Z

src/discounts/components/VoucherSummary/VoucherSummary.tsx

+          />
+        </Typography>
+        <Typography>
+          {maybe<React.ReactNode>(() => voucher.used, <Skeleton />)}


suggestion: We avoid using maybe, instead try something like this:

Suggested change

{maybe<React.ReactNode>(() => voucher.used, <Skeleton />)}

{ voucher?.used ?? <Skeleton />

I have made the suggested change.

Note: Maybe has been used multiple times in the code before. If you look at Voucher Summary file, I made changes to you will find other instances of maybe.

We are aware of it - maybe was used in the codebase when optional chaining (?.) was not yet supported by javascript. We are progressively dropping it.

* add_voucher_used-info#3972 * suggested-update_voucher-used

* Strict TS adjustments * Add datagrid to shipping zones list * Support for bulk delete * Extract messages * Add changeset * Cleanup * Fix stories & fixtures * Fix freeze columns * Replace params.ids with selectedRowIds * Implement search & relocate bulk delete button * Unify margins * Move default weight unit form to TopNav.Menu * Add weight configuration modal * Fix type issue * Add messages * Fix strict mode * Simplify modal closing * Disable dialog when incorrect unit is selected * Move outside render * Disable pricerange column * e2e fixes * Replace combobox with select * shipping method test - remove wait for skeleton * Update macaw-ui * Skip cypress cloud when running e2e tests (#4162) * wip * cr fixes --------- Co-authored-by: Paweł Chyła <pawel.chyla@saleor.io> * Update vite sentry library and handle legacy uploading (#4169) * Handle legacy sentry * Changeset * Increate memory for vite sourcemaps (sentry) (#4173) * Increate memory for vite sourcemaps (sentry) * Changeset * Remove legacy sentry * Use sentry cli (#4175) * use sentry cli * use sentry cli * use sentry cli * Fix rendering of top products on home, when attributes does not have value (#4172) * Fix top product on home * Fix top product on home * Changeset * Fix attribute creation when we change input type (#4177) * Fix attribute creation * Fix attribute creation * Fix layouts for translation edition pages (#4178) * Fix translation pages * Fix translation pages * Update changesets based deployments (#4167) * 3.15.3 release cleanup (#4180) * Fix address form keeps country state from prev address provided (#4188) * Fixes Dashboard crash on quick-menu escape (#4166) * crash-fix#3933 * Update changesets based deployments * Added sk translation (#4144) * Added sk translation * add changeset for SK translation --------- Co-authored-by: Ladislav Hano <524934@mail.muni.cz> * Migrate product page to new macaw (#4125) Co-authored-by: timur <timuric@gmail.com> * Dashboard modal (#4198) * Datagrid cell improvements (#4091) * Implement status cell * Add auto tags cell * Tighten types * Redesign money cell * Add light text color * Add custom date cell * Add color difference * Remove moment * Make font bolder * Add range price * Switch to new date cell * Made font heavier * Make image bigger * Use tag cells * Fixed lint errors * Add percentage display * Fix type errors * Add safety check * Add safety check * Remove duplicate * Enable darkmode support * Fix linter issue * Refactor date cell * Refactor money cell * Rename AutoTags cell to PillCell * TS cleanup * Add changeset * Fix strict mode * Strict TS fixes * Tune dark mode colors * Add fallback for oklch * Fix date cell * Fix tests after oklch fallback is added * Add type - strict mode fix * Reading channel * Conditionally set selected channel based on feature flag * Fix currency crash * Obtain channel * Cleanup * Fix test * Validate date cell * Fix passing incorrect date in order list * Fix invisible dates * Make default width of date column larger on product and order views --------- Co-authored-by: timur <timuric@gmail.com> Co-authored-by: andrzejewsky <vox3r69@gmail.com> * Update release workflow (#4187) * Update relase workflow * Workflow update * Changesets * Ubuntu version * Aws actions update * Add triage status (#4200) * Bug triage * Bug triage * Triage status * Bump @adobe/css-tools from 4.0.1 to 4.3.1 (#4145) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.0.1 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fixed inconsistent capitalization on translation page (#4160) * add_voucher_used-info#3972 (#4161) * add_voucher_used-info#3972 * suggested-update_voucher-used * Epics template (#4202) * Add epic template * Add epic template * Add epic template * Improve text * Fix external app crashing (#4205) * Fix external app crashing * Fix external app crashing * Bump tough-cookie and @cypress/request (#4069) * Bump tough-cookie and @cypress/request Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) and [@cypress/request](https://github.com/cypress-io/request). These dependencies needed to be updated together. Updates `tough-cookie` from 2.5.0 to 4.1.3 - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v2.5.0...v4.1.3) Updates `@cypress/request` from 2.88.11 to 2.88.12 - [Release notes](https://github.com/cypress-io/request/releases) - [Changelog](https://github.com/cypress-io/request/blob/master/CHANGELOG.md) - [Commits](cypress-io/request@v2.88.11...v2.88.12) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect - dependency-name: "@cypress/request" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Trigger CI --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: andrzejewsky <vox3r69@gmail.com> * Fix prepare release workflow dependency (#4207) * Fix workflow * Fix workflow * Handle null * Refactor modal * Change as to satisfies --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: wojteknowacki <wojciech.nowacki@saleor.io> Co-authored-by: wojteknowacki <124166231+wojteknowacki@users.noreply.github.com> Co-authored-by: Paweł Chyła <pawel.chyla@saleor.io> Co-authored-by: Patryk Andrzejewski <vox3r69@gmail.com> Co-authored-by: Krzysztof Żuraw <9116238+krzysztofzuraw@users.noreply.github.com> Co-authored-by: Paweł Chyła <chyla1988@gmail.com> Co-authored-by: Rishi Jain <itsjainrishi@users.noreply.github.com> Co-authored-by: Djkáťo <radovan.katrencik@gmail.com> Co-authored-by: Ladislav Hano <524934@mail.muni.cz> Co-authored-by: timur <timuric@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tushar Rathore <tushh.r1212@gmail.com>

add_voucher_used-info#3972

5bc44ab

itsjainrishi requested review from a team, krzysztofzuraw and Droniu September 4, 2023 04:06

poulch reviewed Sep 4, 2023

View reviewed changes

suggested-update_voucher-used

e40e6de

itsjainrishi force-pushed the add_voucher_used-info branch from 40c01de to e40e6de Compare September 4, 2023 09:51

Droniu approved these changes Sep 4, 2023

View reviewed changes

andrzejewsky approved these changes Sep 18, 2023

View reviewed changes

wojteknowacki self-requested a review September 19, 2023 07:32

wojteknowacki approved these changes Sep 19, 2023

View reviewed changes

andrzejewsky merged commit d4e3052 into saleor:main Sep 19, 2023
13 checks passed

Droniu pushed a commit that referenced this pull request Sep 19, 2023

add_voucher_used-info#3972 (#4161)

cff0dc6

* add_voucher_used-info#3972 * suggested-update_voucher-used

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add_voucher_used-info#3972 #4161

add_voucher_used-info#3972 #4161

itsjainrishi commented Sep 4, 2023 •

edited

Loading

changeset-bot bot commented Sep 4, 2023 •

edited

Loading

CLAassistant commented Sep 4, 2023 •

edited

Loading

CLAassistant commented Sep 4, 2023

poulch Sep 4, 2023

itsjainrishi Sep 4, 2023

Droniu Sep 4, 2023

	{maybe<React.ReactNode>(() => voucher.used, <Skeleton />)}
	{ voucher?.used ?? <Skeleton />

add_voucher_used-info#3972 #4161

add_voucher_used-info#3972 #4161

Conversation

itsjainrishi commented Sep 4, 2023 • edited Loading

Screenshots

Pull Request Checklist

Test environment config

Do you want to run more stable tests?

changeset-bot bot commented Sep 4, 2023 • edited Loading

⚠️ No Changeset found

CLAassistant commented Sep 4, 2023 • edited Loading

CLAassistant commented Sep 4, 2023

poulch Sep 4, 2023

Choose a reason for hiding this comment

itsjainrishi Sep 4, 2023

Choose a reason for hiding this comment

Droniu Sep 4, 2023

Choose a reason for hiding this comment

itsjainrishi commented Sep 4, 2023 •

edited

Loading

changeset-bot bot commented Sep 4, 2023 •

edited

Loading

CLAassistant commented Sep 4, 2023 •

edited

Loading