Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debian): use repository keyring instead of key_id #312

Merged

Conversation

javierbertoli
Copy link
Member

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Debian family is deprecating the use of GPG keys (managed through apt-key) in favor of keyrings.
This PR adds the repositorykeyring when installing from the official repository, and
rewrites the sources.list file accordingly.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@noelmcloughlin
Copy link
Member

I think Tumbleweed is failing because of https://progress.opensuse.org/issues/104193#change-475218 so you could disable that platform - or try a workaround: sed -i 's|download.opensuse|mirrorcache.opensuse|g' *.repo

@javierbertoli javierbertoli force-pushed the debian-family-apt-keyrings branch 3 times, most recently from c4d2464 to 840f148 Compare February 8, 2022 00:20
@javierbertoli javierbertoli force-pushed the debian-family-apt-keyrings branch 2 times, most recently from 49bdeb1 to 37711a2 Compare February 9, 2022 21:46
Copy link
Member

@noelmcloughlin noelmcloughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for resolving CI issues. @javierbertoli

@javierbertoli javierbertoli merged commit cbc7c17 into saltstack-formulas:master Feb 10, 2022
@javierbertoli javierbertoli deleted the debian-family-apt-keyrings branch February 10, 2022 16:32
@saltstack-formulas-travis

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants