-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(debian): use repository keyring instead of key_id #312
feat(debian): use repository keyring instead of key_id #312
Conversation
I think Tumbleweed is failing because of https://progress.opensuse.org/issues/104193#change-475218 so you could disable that platform - or try a workaround: |
c4d2464
to
840f148
Compare
840f148
to
db49eba
Compare
25da5ac
to
410078c
Compare
0e03418
to
5ef7807
Compare
49bdeb1
to
37711a2
Compare
37711a2
to
652da44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for resolving CI issues. @javierbertoli
🎉 This PR is included in version 2.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Use to remove duplicate code introduced in: * saltstack-formulas/nginx-formula#289 * saltstack-formulas/postgres-formula#322 * saltstack-formulas/docker-formula#312
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Debian family is deprecating the use of GPG keys (managed through
apt-key
) in favor ofkeyrings
.This PR adds the repository
keyring
when installing from the official repository, andrewrites the sources.list file accordingly.
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context