-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(debian): use keyrings instead of key_ids #289
feat(debian): use keyrings instead of key_ids #289
Conversation
c57a84d
to
9c3e0c7
Compare
9f13013
to
b76e8cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor changes requested.
6577658
to
2b0db18
Compare
2b0db18
to
c16ecf8
Compare
Merged, thanks for the PR, @javierbertoli. |
🎉 This PR is included in version 2.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@baby-gnu Something that might be interesting to discuss in one of the working group meetings (a potential improvement to the nginx-formula/test/integration/passenger/controls/repository.rb Lines 8 to 16 in ec9559b
|
Use to remove duplicate code introduced in: * saltstack-formulas/nginx-formula#289 * saltstack-formulas/postgres-formula#322 * saltstack-formulas/docker-formula#312
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Debian family is deprecating the use of GPG keys (managed through
apt-key
) in favor ofkeyrings
.This PR adds keyrings both for
nginx
andpassenger
when installed from official repositories, andrewrite the sources.list file accordingly.
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context