Catch recursive objects during msgpack serialize #51322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if this is the best way to handle this, but it's definitely better than blowing up with an exception. Signed-off-by: Wayne Werner <wwerner@saltstack.com>
s0undt3ch
approved these changes
Jan 24, 2019
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
dwoz
added a commit
that referenced
this pull request
Dec 16, 2019
[master] Porting #51322 to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What it says on the tin - catches recursion during payload/msgpack serialization.
What issues does this PR fix or reference?
#37646
Previous Behavior
A return response from a state containing a recursive or cyclical reference, e.g.
Anywhere in a state response would fail trying to serialize it.
New Behavior
Now the message is serialized, with a
<Recursion on ... with id=...>placeholder.I don't know if there's a better way to do that - repr offers
[...]or some such. This follows pprint's style, which is slightly more verbose, so at least when you get the message you might have an idea about what's going on.Tests written?
Yes
Commits signed with GPG?
Yes